All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Christian Bornträger" <borntraeger@de.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: "Cornelia Huck" <cornelia.huck@de.ibm.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()
Date: Mon, 23 Jan 2017 11:08:12 +0000	[thread overview]
Message-ID: <01d581bb-9db6-cba1-e476-49c814c3ebf0@users.sourceforge.net> (raw)
In-Reply-To: <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com>

> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around.

Thanks for such information.


> It does not fix anything and it does not improve the code,

I have got an other expectation for the shown implementation detail.


> but it certainly carries the risk of breaking something

This is usual in software development, isn't it?


> (yes in this case it looks perfectly fine, though).

Thanks for this bit of positive feedback.


> Due to the locking requirements we cannot do such a simplification here.

I find this detail strange. Would you like to check run time consequences
for the shown error code settings once more?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Christian Bornträger" <borntraeger@de.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: "Cornelia Huck" <cornelia.huck@de.ibm.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()
Date: Mon, 23 Jan 2017 12:08:12 +0100	[thread overview]
Message-ID: <01d581bb-9db6-cba1-e476-49c814c3ebf0@users.sourceforge.net> (raw)
In-Reply-To: <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com>

> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around.

Thanks for such information.


> It does not fix anything and it does not improve the code,

I have got an other expectation for the shown implementation detail.


> but it certainly carries the risk of breaking something

This is usual in software development, isn't it?


> (yes in this case it looks perfectly fine, though).

Thanks for this bit of positive feedback.


> Due to the locking requirements we cannot do such a simplification here.

I find this detail strange. Would you like to check run time consequences
for the shown error code settings once more?

Regards,
Markus

  parent reply	other threads:[~2017-01-23 11:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 16:03 [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log() SF Markus Elfring
2017-01-21 16:03 ` SF Markus Elfring
2017-01-23  8:22 ` Christian Borntraeger
2017-01-23  8:22   ` Christian Borntraeger
2017-01-23  9:19   ` Paolo Bonzini
2017-01-23  9:19     ` Paolo Bonzini
2017-01-23 11:08   ` SF Markus Elfring [this message]
2017-01-23 11:08     ` SF Markus Elfring
2017-01-23 11:58     ` Christian Borntraeger
2017-01-23 11:58       ` Christian Borntraeger
2017-01-24 12:10       ` SF Markus Elfring
2017-01-24 12:10         ` SF Markus Elfring
2017-01-24 12:18         ` Paolo Bonzini
2017-01-24 12:18           ` Paolo Bonzini
2017-01-24 12:31           ` SF Markus Elfring
2017-01-24 12:31             ` SF Markus Elfring
2017-01-24 12:38             ` Christian Borntraeger
2017-01-24 12:38               ` Christian Borntraeger
2017-01-24 12:47               ` SF Markus Elfring
2017-01-24 12:47                 ` SF Markus Elfring
2017-01-23 12:21     ` Dan Carpenter
2017-01-23 12:21       ` Dan Carpenter
2017-01-23 13:21       ` SF Markus Elfring
2017-01-23 13:21         ` SF Markus Elfring
2017-01-23 13:37         ` Dan Carpenter
2017-01-23 13:37           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01d581bb-9db6-cba1-e476-49c814c3ebf0@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.