From: Jes Sorensen <jes.sorensen@gmail.com>
To: NeilBrown <neilb@suse.com>
Cc: Peter Rajnoha <prajnoha@redhat.com>,
linux-raid@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [mdadm PATCH] Create: tell udev md device is not ready when first created.
Date: Tue, 2 May 2017 09:42:49 -0400 [thread overview]
Message-ID: <01f50f57-c55e-e87f-b5a1-ded4647368b2@gmail.com> (raw)
In-Reply-To: <87h919ruj5.fsf@notabene.neil.brown.name>
On 04/28/2017 01:05 AM, NeilBrown wrote:
>
> When an array is created the content is not initialized,
> so it could have remnants of an old filesystem or md array
> etc on it.
> udev will see this and might try to activate it, which is almost
> certainly not what is wanted.
>
> So create a mechanism for mdadm to communicate with udev to tell
> it that the device isn't ready. This mechanism is the existance
> of a file /run/mdadm/created-mdXXX where mdXXX is the md device name.
>
> When creating an array, mdadm will create the file.
> A new udev rule file, 01-md-raid-creating.rules, will detect the
> precense of thst file and set ENV{SYSTEMD_READY}="0".
> This is fairly uniformly used to suppress actions based on the
> contents of the device.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> Assemble.c | 2 +-
> Build.c | 2 +-
> Create.c | 9 +++++++-
> Incremental.c | 4 ++--
> Makefile | 4 ++--
> lib.c | 29 +++++++++++++++++++++++++
> mdadm.h | 4 +++-
> mdopen.c | 52 ++++++++++++++++++++++++++++-----------------
> udev-md-raid-creating.rules | 7 ++++++
> 9 files changed, 86 insertions(+), 27 deletions(-)
> create mode 100644 udev-md-raid-creating.rules
Applied!
I like this solution much better, even though I am not in love with the
giant usleep() call. Would be nice to find a better way around that.
Sorry it took so long to get back to you on this, last week was a mess.
Thanks,
Jes
next prev parent reply other threads:[~2017-05-02 13:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:40 [mdadm PATCH 0/4] Assorted mdadm patches NeilBrown
2017-04-20 2:40 ` [mdadm PATCH 2/4] systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts NeilBrown
2017-04-20 16:57 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 1/4] Grow_continue_command: ensure 'content' is properly initialised NeilBrown
2017-04-20 16:56 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 4/4] Create: tell udev device is not ready when first created NeilBrown
2017-04-20 17:29 ` Jes Sorensen
2017-04-20 21:35 ` NeilBrown
2017-04-26 10:19 ` Peter Rajnoha
2017-04-28 3:55 ` NeilBrown
2017-04-28 9:08 ` Peter Rajnoha
2017-05-01 4:35 ` [dm-devel] " NeilBrown
2017-05-02 11:40 ` Peter Rajnoha
2017-05-02 13:40 ` Jes Sorensen
2017-05-03 14:27 ` Peter Rajnoha
2017-05-03 14:41 ` Jes Sorensen
2017-05-02 21:42 ` NeilBrown
2017-04-28 5:05 ` [mdadm PATCH] Create: tell udev md " NeilBrown
2017-04-28 9:28 ` Peter Rajnoha
2017-05-02 13:32 ` Jes Sorensen
2017-05-03 14:13 ` Peter Rajnoha
2017-05-03 14:44 ` Jes Sorensen
2017-05-06 16:25 ` Wols Lists
2017-05-06 19:50 ` Phil Turmel
2017-05-11 13:23 ` Martin Wilck
2017-05-09 11:57 ` Peter Rajnoha
2017-05-09 12:14 ` Peter Rajnoha
2017-05-02 13:42 ` Jes Sorensen [this message]
2017-05-03 14:32 ` Peter Rajnoha
2017-05-03 14:45 ` [dm-devel] " Jes Sorensen
2017-05-04 10:58 ` Peter Rajnoha
2017-05-05 5:16 ` [mdadm PATCH] Fix typo in new udev rule NeilBrown
2017-05-05 15:07 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 3/4] Detail: ensure --export names are acceptable as shell variables NeilBrown
2017-04-20 16:59 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f50f57-c55e-e87f-b5a1-ded4647368b2@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=prajnoha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.