From: Wols Lists <antlists@youngman.org.uk>
To: Peter Rajnoha <prajnoha@redhat.com>,
Jes Sorensen <jes.sorensen@gmail.com>, NeilBrown <neilb@suse.com>
Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [mdadm PATCH] Create: tell udev md device is not ready when first created.
Date: Sat, 6 May 2017 17:25:30 +0100 [thread overview]
Message-ID: <590DF8FA.4090600@youngman.org.uk> (raw)
In-Reply-To: <2f431da6-0dce-b485-4109-6f8669814430@redhat.com>
On 03/05/17 15:13, Peter Rajnoha wrote:
> There's a difference though - when you're *creating* a completely new
> device that is an abstraction over existing devices, you (most of the
> time) expect that new device to be initialized. For those corner cases
> where people do need to keep the old data, there can be an option to do
> that.
That's not a corner case. If there's old data that's the NORM. I get
what you're after, I'm inclined to agree with you, but the default
should be to DO NOTHING.
If you want mdadm to mess about with the content of the drives you
should either (a) explicitly tell it to (yes I would like that option
:-), or (b) do it yourself beforehand - dd if=/dev/zero etc etc.
It does seem weird to me that mdadm spends a lot of effort initialising
an array and calculating parity blah-di-blah, and you can't tell it to
just "set everything to zero". But there's no way it should mess about
with what was there before, without explicitly being told to.
When you're inserting existing drives, you're not creating them -
> when those device come from factory (they're "created"), they never
> contain garbage and old data when you buy them.
As Jes says, USB devices rarely come with nothing on them. MS eventually
learnt their lesson, "doing something" BY DEFAULT with unknown/untrusted
data was a really stupid idea - it was far too easy to get your system
"pwned". Here it would be far too easy to trash an array you're trying
to recover.
Cheers,
Wol
next prev parent reply other threads:[~2017-05-06 16:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:40 [mdadm PATCH 0/4] Assorted mdadm patches NeilBrown
2017-04-20 2:40 ` [mdadm PATCH 2/4] systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts NeilBrown
2017-04-20 16:57 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 1/4] Grow_continue_command: ensure 'content' is properly initialised NeilBrown
2017-04-20 16:56 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 4/4] Create: tell udev device is not ready when first created NeilBrown
2017-04-20 17:29 ` Jes Sorensen
2017-04-20 21:35 ` NeilBrown
2017-04-26 10:19 ` Peter Rajnoha
2017-04-28 3:55 ` NeilBrown
2017-04-28 9:08 ` Peter Rajnoha
2017-05-01 4:35 ` [dm-devel] " NeilBrown
2017-05-02 11:40 ` Peter Rajnoha
2017-05-02 13:40 ` Jes Sorensen
2017-05-03 14:27 ` Peter Rajnoha
2017-05-03 14:41 ` Jes Sorensen
2017-05-02 21:42 ` NeilBrown
2017-04-28 5:05 ` [mdadm PATCH] Create: tell udev md " NeilBrown
2017-04-28 9:28 ` Peter Rajnoha
2017-05-02 13:32 ` Jes Sorensen
2017-05-03 14:13 ` Peter Rajnoha
2017-05-03 14:44 ` Jes Sorensen
2017-05-06 16:25 ` Wols Lists [this message]
2017-05-06 19:50 ` Phil Turmel
2017-05-11 13:23 ` Martin Wilck
2017-05-09 11:57 ` Peter Rajnoha
2017-05-09 12:14 ` Peter Rajnoha
2017-05-02 13:42 ` Jes Sorensen
2017-05-03 14:32 ` Peter Rajnoha
2017-05-03 14:45 ` [dm-devel] " Jes Sorensen
2017-05-04 10:58 ` Peter Rajnoha
2017-05-05 5:16 ` [mdadm PATCH] Fix typo in new udev rule NeilBrown
2017-05-05 15:07 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 3/4] Detail: ensure --export names are acceptable as shell variables NeilBrown
2017-04-20 16:59 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590DF8FA.4090600@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=dm-devel@redhat.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=prajnoha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.