From: Jes Sorensen <jes.sorensen@gmail.com>
To: NeilBrown <neilb@suse.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [mdadm PATCH 3/4] Detail: ensure --export names are acceptable as shell variables.
Date: Thu, 20 Apr 2017 12:59:41 -0400 [thread overview]
Message-ID: <181ac33d-7ee3-53fe-e151-b892998b2b7a@gmail.com> (raw)
In-Reply-To: <149265600586.31004.10549541527467125631.stgit@noble>
On 04/19/2017 10:40 PM, NeilBrown wrote:
> If an array contains a device which has a name that
> contains something other than alphnumerics and underscores,
> then some values reported by "mdadm --detail --export" will
> not be valid as variable assignment of the shell.
> This particularly affects dm devices.
> e.g.
> MD_DEVICE_dm-4_ROLE=1
> MD_DEVICE_dm-4_DEV=/dev/dm-4
>
> As it is particularly useful to be able to work with these
> in a shell script, and as the precise name is not important,
> change all non-alphanumerics to '_'.
>
> MD_DEVICE_dm_4_ROLE=1
> MD_DEVICE_dm_4_DEV=/dev/dm-4
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> Detail.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
Applied!
Thanks,
Jes
next prev parent reply other threads:[~2017-04-20 16:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:40 [mdadm PATCH 0/4] Assorted mdadm patches NeilBrown
2017-04-20 2:40 ` [mdadm PATCH 1/4] Grow_continue_command: ensure 'content' is properly initialised NeilBrown
2017-04-20 16:56 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 2/4] systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts NeilBrown
2017-04-20 16:57 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 3/4] Detail: ensure --export names are acceptable as shell variables NeilBrown
2017-04-20 16:59 ` Jes Sorensen [this message]
2017-04-20 2:40 ` [mdadm PATCH 4/4] Create: tell udev device is not ready when first created NeilBrown
2017-04-20 17:29 ` Jes Sorensen
2017-04-20 21:35 ` NeilBrown
2017-04-26 10:19 ` Peter Rajnoha
2017-04-28 3:55 ` NeilBrown
2017-04-28 9:08 ` Peter Rajnoha
2017-05-01 4:35 ` [dm-devel] " NeilBrown
2017-05-02 11:40 ` Peter Rajnoha
2017-05-02 13:40 ` Jes Sorensen
2017-05-03 14:27 ` Peter Rajnoha
2017-05-03 14:41 ` Jes Sorensen
2017-05-02 21:42 ` NeilBrown
2017-04-28 5:05 ` [mdadm PATCH] Create: tell udev md " NeilBrown
2017-04-28 9:28 ` Peter Rajnoha
2017-05-02 13:32 ` Jes Sorensen
2017-05-03 14:13 ` Peter Rajnoha
2017-05-03 14:44 ` Jes Sorensen
2017-05-06 16:25 ` Wols Lists
2017-05-06 19:50 ` Phil Turmel
2017-05-11 13:23 ` Martin Wilck
2017-05-09 11:57 ` Peter Rajnoha
2017-05-09 12:14 ` Peter Rajnoha
2017-05-02 13:42 ` Jes Sorensen
2017-05-03 14:32 ` Peter Rajnoha
2017-05-03 14:45 ` [dm-devel] " Jes Sorensen
2017-05-04 10:58 ` Peter Rajnoha
2017-05-05 5:16 ` [mdadm PATCH] Fix typo in new udev rule NeilBrown
2017-05-05 15:07 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181ac33d-7ee3-53fe-e151-b892998b2b7a@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.