Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'

[SeokYeon Hwang <syeon.hwang@samsung.com>]

> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Wednesday, November 12, 2014 4:33 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; kongjianjun@gmail.com; paolo.bonzini@gmail.com;
> mreitz@redhat.com; qemu-trivial@nongnu.org; Michael S. Tsirkin
> Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno
> to 'error_set_errno()'
> 
> Copying maintainer and -trivial.
> 
> In the future, please copy maintainers.  You can use
> "scripts/get_maintainer.pl --no-git-fallback" to find them.

Thank you for your help.

> 
> SeokYeon Hwang <syeon.hwang@samsung.com> writes:
> 
> > Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> > ---
> >  hw/pci/pcie.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d
> > 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice
> *hotplug_dev,
> >          /* the slot is electromechanically locked.
> >           * This error is propagated up to qdev and then to HMP/QMP.
> >           */
> > -        error_setg_errno(errp, -EBUSY, "slot is electromechanically
> locked");
> > +        error_setg_errno(errp, EBUSY, "slot is electromechanically
> > + locked");
> >      }
> >  }
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>