From: Max Reitz <mreitz@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
Date: Wed, 12 Nov 2014 09:30:33 +0100 [thread overview]
Message-ID: <54631AA9.1050008@redhat.com> (raw)
In-Reply-To: <1415775949-4528-1-git-send-email-syeon.hwang@samsung.com>
On 2014-11-12 at 08:05, SeokYeon Hwang wrote:
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd..2902f7d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
> /* the slot is electromechanically locked.
> * This error is propagated up to qdev and then to HMP/QMP.
> */
> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
> }
> }
Reviewed-by: Max Reitz <mreitz@redhat.com>
prev parent reply other threads:[~2014-11-12 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 7:05 [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' SeokYeon Hwang
2014-11-12 7:33 ` [Qemu-trivial] " Markus Armbruster
2014-11-12 7:33 ` Markus Armbruster
2014-11-12 7:43 ` [Qemu-trivial] " SeokYeon Hwang
2014-11-12 7:43 ` SeokYeon Hwang
2014-11-12 8:30 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54631AA9.1050008@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kongjianjun@gmail.com \
--cc=paolo.bonzini@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.