* [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
@ 2014-11-12 7:05 SeokYeon Hwang
2014-11-12 7:33 ` Markus Armbruster
2014-11-12 8:30 ` Max Reitz
0 siblings, 2 replies; 6+ messages in thread
From: SeokYeon Hwang @ 2014-11-12 7:05 UTC (permalink / raw)
To: qemu-devel; +Cc: kongjianjun, paolo.bonzini, armbru, mreitz, SeokYeon Hwang
Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 58455bd..2902f7d 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
/* the slot is electromechanically locked.
* This error is propagated up to qdev and then to HMP/QMP.
*/
- error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
+ error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
}
}
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
2014-11-12 7:05 [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' SeokYeon Hwang
@ 2014-11-12 7:33 ` Markus Armbruster
2014-11-12 8:30 ` Max Reitz
1 sibling, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-11-12 7:33 UTC (permalink / raw)
To: SeokYeon Hwang
Cc: Michael S. Tsirkin, qemu-trivial, kongjianjun, paolo.bonzini,
qemu-devel, mreitz
Copying maintainer and -trivial.
In the future, please copy maintainers. You can use
"scripts/get_maintainer.pl --no-git-fallback" to find them.
SeokYeon Hwang <syeon.hwang@samsung.com> writes:
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd..2902f7d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
> /* the slot is electromechanically locked.
> * This error is propagated up to qdev and then to HMP/QMP.
> */
> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
> }
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
@ 2014-11-12 7:33 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-11-12 7:33 UTC (permalink / raw)
To: SeokYeon Hwang
Cc: Michael S. Tsirkin, qemu-trivial, kongjianjun, paolo.bonzini,
qemu-devel, mreitz
Copying maintainer and -trivial.
In the future, please copy maintainers. You can use
"scripts/get_maintainer.pl --no-git-fallback" to find them.
SeokYeon Hwang <syeon.hwang@samsung.com> writes:
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd..2902f7d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
> /* the slot is electromechanically locked.
> * This error is propagated up to qdev and then to HMP/QMP.
> */
> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
> }
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
2014-11-12 7:33 ` Markus Armbruster
@ 2014-11-12 7:43 ` SeokYeon Hwang
-1 siblings, 0 replies; 6+ messages in thread
From: SeokYeon Hwang @ 2014-11-12 7:43 UTC (permalink / raw)
To: 'Markus Armbruster'
Cc: 'Michael S. Tsirkin', qemu-trivial, kongjianjun,
paolo.bonzini, qemu-devel, mreitz
> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Wednesday, November 12, 2014 4:33 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; kongjianjun@gmail.com; paolo.bonzini@gmail.com;
> mreitz@redhat.com; qemu-trivial@nongnu.org; Michael S. Tsirkin
> Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno
> to 'error_set_errno()'
>
> Copying maintainer and -trivial.
>
> In the future, please copy maintainers. You can use
> "scripts/get_maintainer.pl --no-git-fallback" to find them.
Thank you for your help.
>
> SeokYeon Hwang <syeon.hwang@samsung.com> writes:
>
> > Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> > ---
> > hw/pci/pcie.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d
> > 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice
> *hotplug_dev,
> > /* the slot is electromechanically locked.
> > * This error is propagated up to qdev and then to HMP/QMP.
> > */
> > - error_setg_errno(errp, -EBUSY, "slot is electromechanically
> locked");
> > + error_setg_errno(errp, EBUSY, "slot is electromechanically
> > + locked");
> > }
> > }
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
@ 2014-11-12 7:43 ` SeokYeon Hwang
0 siblings, 0 replies; 6+ messages in thread
From: SeokYeon Hwang @ 2014-11-12 7:43 UTC (permalink / raw)
To: 'Markus Armbruster'
Cc: 'Michael S. Tsirkin', qemu-trivial, kongjianjun,
paolo.bonzini, qemu-devel, mreitz
> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Wednesday, November 12, 2014 4:33 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; kongjianjun@gmail.com; paolo.bonzini@gmail.com;
> mreitz@redhat.com; qemu-trivial@nongnu.org; Michael S. Tsirkin
> Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno
> to 'error_set_errno()'
>
> Copying maintainer and -trivial.
>
> In the future, please copy maintainers. You can use
> "scripts/get_maintainer.pl --no-git-fallback" to find them.
Thank you for your help.
>
> SeokYeon Hwang <syeon.hwang@samsung.com> writes:
>
> > Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> > ---
> > hw/pci/pcie.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d
> > 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice
> *hotplug_dev,
> > /* the slot is electromechanically locked.
> > * This error is propagated up to qdev and then to HMP/QMP.
> > */
> > - error_setg_errno(errp, -EBUSY, "slot is electromechanically
> locked");
> > + error_setg_errno(errp, EBUSY, "slot is electromechanically
> > + locked");
> > }
> > }
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'
2014-11-12 7:05 [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' SeokYeon Hwang
2014-11-12 7:33 ` Markus Armbruster
@ 2014-11-12 8:30 ` Max Reitz
1 sibling, 0 replies; 6+ messages in thread
From: Max Reitz @ 2014-11-12 8:30 UTC (permalink / raw)
To: SeokYeon Hwang, qemu-devel; +Cc: kongjianjun, paolo.bonzini, armbru
On 2014-11-12 at 08:05, SeokYeon Hwang wrote:
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd..2902f7d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
> /* the slot is electromechanically locked.
> * This error is propagated up to qdev and then to HMP/QMP.
> */
> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
> }
> }
Reviewed-by: Max Reitz <mreitz@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-12 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 7:05 [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' SeokYeon Hwang
2014-11-12 7:33 ` [Qemu-trivial] " Markus Armbruster
2014-11-12 7:33 ` Markus Armbruster
2014-11-12 7:43 ` [Qemu-trivial] " SeokYeon Hwang
2014-11-12 7:43 ` SeokYeon Hwang
2014-11-12 8:30 ` Max Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.