All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Peter <sven@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Felipe Balbi <balbi@kernel.org>, Janne Grunau <j@jannau.net>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Neal Gompa <neal@gompa.dev>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"asahi@lists.linux.dev" <asahi@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init
Date: Sat, 23 Aug 2025 11:32:23 +0200	[thread overview]
Message-ID: <0289f92d-0d18-43d2-b98a-da8bb08e9342@kernel.org> (raw)
In-Reply-To: <20250821221832.zsn4rk7nomsbgytx@synopsys.com>

Hi Thinh,

On 22.08.25 00:18, Thinh Nguyen wrote:
> For this patch, however, I'd prefer these vendor-specific settings to be
> in their own glue driver. I can only imagine more changes will be
> introduced in the future with this vendor. See if we can use the new
> glue interface in glue.h (some call this the new "flatten" model) when
> creating a glue driver.

Nice, thanks! Hints like that are exactly what I was hoping for when
I sent this RFC.

When I originally started working on this I tried to use the 
parent/child model but didn't really get anywhere. This flattened model 
looks very useful though.

I think I can even move some of logic from the previous commits to 
dwc3-apple.c if I extend the glue a little bit. I'll see how that works 
out and maybe do that for the next version then.

Thanks,

Sven


WARNING: multiple messages have this Message-ID (diff)
From: Sven Peter <sven@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Felipe Balbi <balbi@kernel.org>, Janne Grunau <j@jannau.net>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Neal Gompa <neal@gompa.dev>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"asahi@lists.linux.dev" <asahi@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init
Date: Sat, 23 Aug 2025 11:32:23 +0200	[thread overview]
Message-ID: <0289f92d-0d18-43d2-b98a-da8bb08e9342@kernel.org> (raw)
In-Reply-To: <20250821221832.zsn4rk7nomsbgytx@synopsys.com>

Hi Thinh,

On 22.08.25 00:18, Thinh Nguyen wrote:
> For this patch, however, I'd prefer these vendor-specific settings to be
> in their own glue driver. I can only imagine more changes will be
> introduced in the future with this vendor. See if we can use the new
> glue interface in glue.h (some call this the new "flatten" model) when
> creating a glue driver.

Nice, thanks! Hints like that are exactly what I was hoping for when
I sent this RFC.

When I originally started working on this I tried to use the 
parent/child model but didn't really get anywhere. This flattened model 
looks very useful though.

I think I can even move some of logic from the previous commits to 
dwc3-apple.c if I extend the glue a little bit. I'll see how that works 
out and maybe do that for the next version then.

Thanks,

Sven


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2025-08-23  9:32 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 15:38 [PATCH RFC 00/22] Apple Silicon USB3 support Sven Peter
2025-08-21 15:38 ` Sven Peter
2025-08-21 15:38 ` [PATCH RFC 01/22] dt-bindings: usb: snps,dwc3: Allow multiple iommus Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 22:39   ` Rob Herring (Arm)
2025-08-21 22:39     ` Rob Herring (Arm)
2025-08-22  7:22   ` Krzysztof Kozlowski
2025-08-22  7:22     ` Krzysztof Kozlowski
2025-08-24  8:31     ` Krzysztof Kozlowski
2025-08-24  8:31       ` Krzysztof Kozlowski
2025-08-27 16:07       ` Sven Peter
2025-08-27 16:07         ` Sven Peter
2025-08-28  6:54         ` Krzysztof Kozlowski
2025-08-28  6:54           ` Krzysztof Kozlowski
2025-08-21 15:38 ` [PATCH RFC 02/22] dt-bindings: usb: Add Apple dwc3 Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 22:39   ` Rob Herring (Arm)
2025-08-21 22:39     ` Rob Herring (Arm)
2025-08-22  7:24   ` Krzysztof Kozlowski
2025-08-22  7:24     ` Krzysztof Kozlowski
2025-08-24 15:30     ` Sven Peter
2025-08-24 15:30       ` Sven Peter
2025-08-21 15:38 ` [PATCH RFC 03/22] dt-bindings: phy: Add Apple Type-C PHY Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 16:33   ` Janne Grunau
2025-08-21 16:33     ` Janne Grunau
2025-08-21 23:00     ` Rob Herring
2025-08-21 23:00       ` Rob Herring
2025-08-24 15:33       ` Sven Peter
2025-08-24 15:33         ` Sven Peter
2025-08-21 22:39   ` Rob Herring (Arm)
2025-08-21 22:39     ` Rob Herring (Arm)
2025-08-21 15:38 ` [PATCH RFC 04/22] usb: dwc3: apple: Reset dwc3 during role switches Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 23:25   ` Thinh Nguyen
2025-08-21 23:25     ` Thinh Nguyen
2025-08-24 13:18     ` Janne Grunau
2025-08-24 13:18       ` Janne Grunau
2025-08-28 23:07       ` Thinh Nguyen
2025-08-28 23:07         ` Thinh Nguyen
2025-08-24 15:24     ` Sven Peter
2025-08-24 15:24       ` Sven Peter
2025-08-28 23:14       ` Thinh Nguyen
2025-08-28 23:14         ` Thinh Nguyen
2025-08-21 15:38 ` [PATCH RFC 05/22] usb: dwc3: apple: Do not use host-vbus-glitches workaround Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 22:28   ` Thinh Nguyen
2025-08-21 22:28     ` Thinh Nguyen
2025-08-23 11:42     ` Sven Peter
2025-08-23 11:42       ` Sven Peter
2025-08-28 23:06       ` Thinh Nguyen
2025-08-28 23:06         ` Thinh Nguyen
2025-08-21 15:38 ` [PATCH RFC 06/22] usb: dwc3: apple: Use synchronous role switch for apple Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 15:38 ` [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init Sven Peter
2025-08-21 15:38   ` Sven Peter
2025-08-21 22:18   ` Thinh Nguyen
2025-08-21 22:18     ` Thinh Nguyen
2025-08-23  9:32     ` Sven Peter [this message]
2025-08-23  9:32       ` Sven Peter
2025-08-28 22:51       ` Thinh Nguyen
2025-08-28 22:51         ` Thinh Nguyen
2025-08-21 15:39 ` [PATCH RFC 08/22] usb: typec: tipd: Clear interrupts first Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-29  9:37   ` Heikki Krogerus
2025-08-29  9:37     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 09/22] usb: typec: tipd: Move initial irq mask to tipd_data Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:03   ` Heikki Krogerus
2025-09-05 11:03     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 10/22] usb: typec: tipd: Move switch_power_state " Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:09   ` Heikki Krogerus
2025-09-05 11:09     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 11/22] usb: typec: tipd: Trace data status for CD321x correctly Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:11   ` Heikki Krogerus
2025-09-05 11:11     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 12/22] usb: typec: tipd: Add cd321x struct with separate size Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:15   ` Heikki Krogerus
2025-09-05 11:15     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 13/22] usb: typec: tipd: Read USB4, Thunderbolt and DisplayPort status for cd321x Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 16:46   ` Janne Grunau
2025-08-21 16:46     ` Janne Grunau
2025-08-21 15:39 ` [PATCH RFC 14/22] usb: typec: tipd: Register DisplayPort and Thunderbolt altmodes " Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:20   ` Heikki Krogerus
2025-09-05 11:20     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 15/22] usb: typec: tipd: Update partner identity when power status was updated Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-09-05 11:40   ` Heikki Krogerus
2025-09-05 11:40     ` Heikki Krogerus
2025-08-21 15:39 ` [PATCH RFC 16/22] usb: typec: tipd: Use read_power_status function in probe Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 17/22] usb: typec: tipd: Read data status in probe and cache its value Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 18/22] usb: typec: mux: Introduce data_role to mux state Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 19/22] usb: typec: tipd: Handle mode transitions for CD321x Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 20/22] soc: apple: Add hardware tunable support Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 21/22] phy: apple: Add Apple Type-C PHY Sven Peter
2025-08-21 15:39   ` Sven Peter
2025-08-21 15:39 ` [PATCH RFC 22/22] arm64: dts: apple: t8103: Add Apple Type-C PHY and dwc3 nodes Sven Peter
2025-08-21 15:39   ` Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0289f92d-0d18-43d2-b98a-da8bb08e9342@kernel.org \
    --to=sven@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=balbi@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=j@jannau.net \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=neal@gompa.dev \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.