* [PATCH 1/5 linux-next] IB/mlx5: remove unneccessary message level.
@ 2015-03-30 20:06 ` Fabian Frederick
0 siblings, 0 replies; 9+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:06 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Eli Cohen, Roland Dreier, Sean Hefty,
Hal Rosenstock, linux-rdma
KERN_ERR is implicitely declared in pr_err()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/infiniband/hw/mlx5/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index be0cd35..e5b4253 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -1394,7 +1394,7 @@ static int mlx5_set_path(struct mlx5_ib_dev *dev, const struct ib_ah_attr *ah,
if (ah->ah_flags & IB_AH_GRH) {
if (ah->grh.sgid_index >= gen->port[port - 1].gid_table_len) {
- pr_err(KERN_ERR "sgid_index (%u) too large. max is %d\n",
+ pr_err("sgid_index (%u) too large. max is %d\n",
ah->grh.sgid_index, gen->port[port - 1].gid_table_len);
return -EINVAL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5 linux-next] iw_cxgb4: remove unneccessary message level.
2015-03-30 20:06 ` Fabian Frederick
(?)
@ 2015-03-30 20:06 ` Fabian Frederick
2015-03-30 20:17 ` Steve Wise
-1 siblings, 1 reply; 9+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:06 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Steve Wise, Roland Dreier, Sean Hefty,
Hal Rosenstock, linux-rdma
KERN_ERR is implicitely declared in pr_err()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/infiniband/hw/cxgb4/device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index 8fb295e..59546b6 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -1355,7 +1355,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
t4_sq_host_wq_pidx(&qp->wq),
t4_sq_wq_size(&qp->wq));
if (ret) {
- pr_err(KERN_ERR MOD "%s: Fatal error - "
+ pr_err(MOD "%s: Fatal error - "
"DB overflow recovery failed - "
"error syncing SQ qid %u\n",
pci_name(ctx->lldi.pdev), qp->wq.sq.qid);
@@ -1371,7 +1371,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
t4_rq_wq_size(&qp->wq));
if (ret) {
- pr_err(KERN_ERR MOD "%s: Fatal error - "
+ pr_err(MOD "%s: Fatal error - "
"DB overflow recovery failed - "
"error syncing RQ qid %u\n",
pci_name(ctx->lldi.pdev), qp->wq.rq.qid);
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5 linux-next] IB/mlx4: remove unneccessary message level.
2015-03-30 20:06 ` Fabian Frederick
(?)
(?)
@ 2015-03-30 20:06 ` Fabian Frederick
-1 siblings, 0 replies; 9+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:06 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma
KERN_WARNING is implicitely declared in pr_warn()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/infiniband/hw/mlx4/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index b972c0b..1298fe8 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -1568,8 +1568,7 @@ static void reset_gids_task(struct work_struct *work)
MLX4_CMD_TIME_CLASS_B,
MLX4_CMD_WRAPPED);
if (err)
- pr_warn(KERN_WARNING
- "set port %d command failed\n", gw->port);
+ pr_warn("set port %d command failed\n", gw->port);
}
mlx4_free_cmd_mailbox(dev, mailbox);
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5 linux-next] fotg210-hcd: remove unneccessary message level.
2015-03-30 20:06 ` Fabian Frederick
` (2 preceding siblings ...)
(?)
@ 2015-03-30 20:06 ` Fabian Frederick
-1 siblings, 0 replies; 9+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Greg Kroah-Hartman, linux-usb
KERN_WARNING is implicitely declared in pr_warn()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 475b21f..98b0d05 100644
--- a/drivers/usb/host/fotg210-hcd.c
+++ b/drivers/usb/host/fotg210-hcd.c
@@ -5914,7 +5914,7 @@ static int __init fotg210_hcd_init(void)
set_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) ||
test_bit(USB_OHCI_LOADED, &usb_hcds_loaded))
- pr_warn(KERN_WARNING "Warning! fotg210_hcd should always be loaded before uhci_hcd and ohci_hcd, not after\n");
+ pr_warn("Warning! fotg210_hcd should always be loaded before uhci_hcd and ohci_hcd, not after\n");
pr_debug("%s: block sizes: qh %Zd qtd %Zd itd %Zd\n",
hcd_name,
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5 linux-next] tpm_ibmvtpm: remove unneccessary message level.
2015-03-30 20:06 ` Fabian Frederick
` (3 preceding siblings ...)
(?)
@ 2015-03-30 20:06 ` Fabian Frederick
2015-03-30 20:42 ` Peter Hüwe
-1 siblings, 1 reply; 9+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:06 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Peter Huewe, Marcel Selhorst, Jason Gunthorpe,
tpmdd-devel
KERN_ERR is implicitely declared in pr_err()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/char/tpm/tpm_of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..eebe625 100644
--- a/drivers/char/tpm/tpm_of.c
+++ b/drivers/char/tpm/tpm_of.c
@@ -49,7 +49,7 @@ int read_log(struct tpm_bios_log *log)
basep = of_get_property(np, "linux,sml-base", NULL);
if (basep == NULL) {
- pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__);
+ pr_err("%s: ERROR - SML not found\n", __func__);
goto cleanup_eio;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 5/5 linux-next] tpm_ibmvtpm: remove unneccessary message level.
2015-03-30 20:06 ` [PATCH 5/5 linux-next] tpm_ibmvtpm: " Fabian Frederick
@ 2015-03-30 20:42 ` Peter Hüwe
0 siblings, 0 replies; 9+ messages in thread
From: Peter Hüwe @ 2015-03-30 20:42 UTC (permalink / raw)
To: Fabian Frederick
Cc: linux-kernel, Marcel Selhorst, Jason Gunthorpe, tpmdd-devel
Am Montag, 30. März 2015, 22:06:08 schrieb Fabian Frederick:
> KERN_ERR is implicitely declared in pr_err()
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Good catch.
Acked-by: Peter Huewe <peterhuewe@gmx.de>
If nobody else pulls this one through his tree, I'll apply it probably for
4._2_ (so it might take a while)
Peter
> ---
> drivers/char/tpm/tpm_of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
> index c002d1b..eebe625 100644
> --- a/drivers/char/tpm/tpm_of.c
> +++ b/drivers/char/tpm/tpm_of.c
> @@ -49,7 +49,7 @@ int read_log(struct tpm_bios_log *log)
>
> basep = of_get_property(np, "linux,sml-base", NULL);
> if (basep == NULL) {
> - pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__);
> + pr_err("%s: ERROR - SML not found\n", __func__);
> goto cleanup_eio;
> }
^ permalink raw reply [flat|nested] 9+ messages in thread