From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH 2/4] nvmet-rdma: notify QP on Last WQE Reached event arrival
Date: Wed, 17 Jan 2018 09:37:02 -0600 [thread overview]
Message-ID: <02bf01d38fa9$05254550$0f6fcff0$@opengridcomputing.com> (raw)
In-Reply-To: <1516197178-26493-3-git-send-email-maxg@mellanox.com>
>
> In order to avoid resource leakage for QP associated with
> a Shared Receive Queue (SRQ), notify it on Last WQE Reached
> event arrival.
>
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> drivers/nvme/target/rdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 4991290..99a14a7 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1151,6 +1151,9 @@ static void nvmet_rdma_qp_event(struct ib_event
> *event, void *priv)
> case IB_EVENT_COMM_EST:
> rdma_notify(queue->cm_id, event->event);
> break;
> + case IB_EVENT_QP_LAST_WQE_REACHED:
> + ib_notify_qp(queue->cm_id->qp, event->event);
> + break;
> default:
> pr_err("received IB QP event: %s (%d)\n",
> ib_event_msg(event->event), event->event);
I wonder if this could be handled in ib_dispatch_event() for all ULPS?
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Max Gurtovoy' <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
bart.vanassche-Sjgp3cTcYWE@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org
Cc: danielm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: RE: [PATCH 2/4] nvmet-rdma: notify QP on Last WQE Reached event arrival
Date: Wed, 17 Jan 2018 09:37:02 -0600 [thread overview]
Message-ID: <02bf01d38fa9$05254550$0f6fcff0$@opengridcomputing.com> (raw)
In-Reply-To: <1516197178-26493-3-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> In order to avoid resource leakage for QP associated with
> a Shared Receive Queue (SRQ), notify it on Last WQE Reached
> event arrival.
>
> Signed-off-by: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/nvme/target/rdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 4991290..99a14a7 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1151,6 +1151,9 @@ static void nvmet_rdma_qp_event(struct ib_event
> *event, void *priv)
> case IB_EVENT_COMM_EST:
> rdma_notify(queue->cm_id, event->event);
> break;
> + case IB_EVENT_QP_LAST_WQE_REACHED:
> + ib_notify_qp(queue->cm_id->qp, event->event);
> + break;
> default:
> pr_err("received IB QP event: %s (%d)\n",
> ib_event_msg(event->event), event->event);
I wonder if this could be handled in ib_dispatch_event() for all ULPS?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-17 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 13:52 [PATCH 0/4] Last WQE Reached event treatment Max Gurtovoy
2018-01-17 13:52 ` Max Gurtovoy
2018-01-17 13:52 ` [PATCH 1/4] IB/core: add support for draining Shared receive queues Max Gurtovoy
2018-01-17 13:52 ` Max Gurtovoy
2018-01-17 15:35 ` Steve Wise
2018-01-17 15:35 ` Steve Wise
2018-01-18 18:06 ` Bart Van Assche
2018-01-18 18:06 ` Bart Van Assche
2018-01-17 16:11 ` Bart Van Assche
2018-01-17 16:11 ` Bart Van Assche
2018-01-18 10:31 ` Max Gurtovoy
2018-01-18 10:31 ` Max Gurtovoy
2018-01-24 6:39 ` Sagi Grimberg
2018-01-24 6:39 ` Sagi Grimberg
2018-01-24 10:20 ` Max Gurtovoy
2018-01-24 10:20 ` Max Gurtovoy
2018-01-17 13:52 ` [PATCH 2/4] nvmet-rdma: notify QP on Last WQE Reached event arrival Max Gurtovoy
2018-01-17 13:52 ` Max Gurtovoy
2018-01-17 15:37 ` Steve Wise [this message]
2018-01-17 15:37 ` Steve Wise
2018-01-18 18:04 ` Bart Van Assche
2018-01-18 18:04 ` Bart Van Assche
2018-01-17 13:52 ` [PATCH 3/4] iser-target: remove dead code Max Gurtovoy
2018-01-17 13:52 ` Max Gurtovoy
2018-01-17 13:52 ` [PATCH 4/4] IB/srpt: notify QP on Last WQE Reached event arrival Max Gurtovoy
2018-01-17 13:52 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02bf01d38fa9$05254550$0f6fcff0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.