Re: [PATCH mptcp-next v2 00/12] mptcp: receive path improvement

[Geliang Tang <geliang@kernel.org>]

Hi Paolo,

On Thu, 2025-09-18 at 20:33 +0000, MPTCP CI wrote:
> Hi Paolo,
> 
> Thank you for your modifications, that's great!
> 
> Our CI did some validations and here is its report:
> 
> - KVM Validation: normal: Unstable: 5 failed test(s):
> packetdrill_mp_capable selftest_mptcp_connect
> selftest_mptcp_connect_checksum selftest_mptcp_connect_mmap
> selftest_mptcp_connect_sendfile 🔴
> - KVM Validation: debug: Unstable: 5 failed test(s):
> packetdrill_mp_capable selftest_mptcp_connect
> selftest_mptcp_connect_checksum selftest_mptcp_connect_mmap
> selftest_mptcp_connect_sendfile 🔴
> - KVM Validation: btf-normal (only bpftest_all): Success! ✅
> - KVM Validation: btf-debug (only bpftest_all): Success! ✅
> - Task:
> https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17836736262

CI reports that this series breaks the mptcp_connect.sh test:

# INFO: disconnect
# 63 ns1 MPTCP -> ns1 (10.0.1.1:20001      ) MPTCP     (duration 
1348ms) [ OK ]
# 64 ns1 MPTCP -> ns1 (10.0.1.1:20002      ) TCP       main_loop_s:
timed out
# (duration 61185ms) [FAIL] client exit code 124, server 2
# 
# netns ns1-HugJD9 (listener) socket stat for 20002:
# Netid State     Recv-Q Send-Q Local Address:Port  Peer Address:Port 
# tcp   TIME-WAIT 0      0           10.0.1.1:20002     10.0.1.1:47722
timer:(timewait,,0) ino:0 sk:2066
# ^I
# TcpActiveOpens                  2                  0.0
# TcpPassiveOpens                 2                  0.0

I also tested it on my end and found that starting from patch 8 "mptcp:
cleanup fallback data fin reception", the mptcp_connect.sh test has
been failing.

I apologize for not providing this feedback during the v1 review, but I
was too busy yesterday to complete the testing.

Thanks,
-Geliang

> 
> Initiator: Patchew Applier
> Commits:
> https://github.com/multipath-tcp/mptcp_net-next/commits/20282b41a458
> Patchwork:
> https://patchwork.kernel.org/project/mptcp/list/?series=1003937
> 
> 
> If there are some issues, you can reproduce them using the same
> environment as
> the one used by the CI thanks to a docker image, e.g.:
> 
>     $ cd [kernel source code]
>     $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm
> -it \
>         --pull always mptcp/mptcp-upstream-virtme-docker:latest \
>         auto-normal
> 
> For more details:
> 
>     https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
> 
> 
> Please note that despite all the efforts that have been already done
> to have a
> stable tests suite when executed on a public CI like here, it is
> possible some
> reported issues are not due to your modifications. Still, do not
> hesitate to
> help us improve that ;-)
> 
> Cheers,
> MPTCP GH Action bot
> Bot operated by Matthieu Baerts (NGI0 Core)