From: Geliang Tang <geliang@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 02/12] tcp: make tcp_rcvbuf_grow() accessible to mptcp code
Date: Fri, 19 Sep 2025 17:50:04 +0800 [thread overview]
Message-ID: <ceb0c39637fec1cb0d10520db53acbedf8fc7f08.camel@kernel.org> (raw)
In-Reply-To: <d5fe01b8d262752dea8db8653e12aa9e9685b7e7.1758214563.git.pabeni@redhat.com>
On Thu, 2025-09-18 at 19:14 +0200, Paolo Abeni wrote:
> To leverage the auto-tuning improvements brought by commit
> 2da35e4b4df9
> ("Merge branch 'tcp-receive-side-improvements'"), the MPTCP stack
> need
> to access the mentioned helper.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
LGTM!
Reviewed-by: Geliang Tang <geliang@kernel.org>
Tested-by: Geliang Tang <geliang@kernel.org>
Thanks,
-Geliang
> ---
> include/net/tcp.h | 1 +
> net/ipv4/tcp_input.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index e25340459ce4a..db2a4e05147fa 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -356,6 +356,7 @@ void tcp_delack_timer_handler(struct sock *sk);
> int tcp_ioctl(struct sock *sk, int cmd, int *karg);
> enum skb_drop_reason tcp_rcv_state_process(struct sock *sk, struct
> sk_buff *skb);
> void tcp_rcv_established(struct sock *sk, struct sk_buff *skb);
> +void tcp_rcvbuf_grow(struct sock *sk);
> void tcp_rcv_space_adjust(struct sock *sk);
> int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp);
> void tcp_twsk_destructor(struct sock *sk);
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index b2793e749cfd9..ad09995a1aaec 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -701,7 +701,7 @@ static inline void tcp_rcv_rtt_measure_ts(struct
> sock *sk,
> }
> }
>
> -static void tcp_rcvbuf_grow(struct sock *sk)
> +void tcp_rcvbuf_grow(struct sock *sk)
> {
> const struct net *net = sock_net(sk);
> struct tcp_sock *tp = tcp_sk(sk);
next prev parent reply other threads:[~2025-09-19 9:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 17:14 [PATCH mptcp-next v2 00/12] mptcp: receive path improvement Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 01/12] mptcp: leverage skb deferral free Paolo Abeni
2025-09-19 9:49 ` Geliang Tang
2025-09-19 10:21 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 02/12] tcp: make tcp_rcvbuf_grow() accessible to mptcp code Paolo Abeni
2025-09-19 9:50 ` Geliang Tang [this message]
2025-09-19 10:22 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 03/12] mptcp: rcvbuf auto-tuning improvement Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 10:22 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 04/12] mptcp: introduce the mptcp_init_skb helper Paolo Abeni
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 05/12] mptcp: remove unneeded mptcp_move_skb() Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 06/12] mptcp: factor out a basic skb coalesce helper Paolo Abeni
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 07/12] mptcp: minor move_skbs_to_msk() cleanup Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 12:36 ` Matthieu Baerts
2025-09-19 15:01 ` Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 08/12] mptcp: cleanup fallback data fin reception Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 09/12] mptcp: leverage the sk backlog for RX packet processing Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 10/12] mptcp: prevernt __mptcp_move_skbs() interfering with the fastpath Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 11/12] mptcp: borrow forward memory from subflow Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 12/12] mptcp: make fallback backlog aware Paolo Abeni
2025-09-18 20:33 ` [PATCH mptcp-next v2 00/12] mptcp: receive path improvement MPTCP CI
2025-09-19 2:22 ` Geliang Tang
2025-09-19 6:54 ` Paolo Abeni
2025-09-19 7:30 ` Geliang Tang
2025-09-19 8:14 ` Matthieu Baerts
2025-09-19 13:11 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb0c39637fec1cb0d10520db53acbedf8fc7f08.camel@kernel.org \
--to=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.