From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 07/12] mptcp: minor move_skbs_to_msk() cleanup
Date: Fri, 19 Sep 2025 14:36:57 +0200 [thread overview]
Message-ID: <91594ac4-386b-4fbd-bc65-3bc302bf0e39@kernel.org> (raw)
In-Reply-To: <7874130ef3d034155655104b22712fa3c3c1d028.1758214564.git.pabeni@redhat.com>
Hi Paolo,
On 18/09/2025 19:14, Paolo Abeni wrote:
> Such function is called only by __mptcp_data_ready(), which in turn
> is always invoked when msk is not owned by the user: we can drop the
> redundant, related check.
>
> Additionally mptcp needs to propagate the socket error only for
> current subflow.
Ah yes, good point! Should this be considered as a dedicated fix or is
the impact not important?
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-09-19 12:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 17:14 [PATCH mptcp-next v2 00/12] mptcp: receive path improvement Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 01/12] mptcp: leverage skb deferral free Paolo Abeni
2025-09-19 9:49 ` Geliang Tang
2025-09-19 10:21 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 02/12] tcp: make tcp_rcvbuf_grow() accessible to mptcp code Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 10:22 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 03/12] mptcp: rcvbuf auto-tuning improvement Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 10:22 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 04/12] mptcp: introduce the mptcp_init_skb helper Paolo Abeni
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 05/12] mptcp: remove unneeded mptcp_move_skb() Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 06/12] mptcp: factor out a basic skb coalesce helper Paolo Abeni
2025-09-19 12:36 ` Matthieu Baerts
2025-09-18 17:14 ` [PATCH mptcp-next v2 07/12] mptcp: minor move_skbs_to_msk() cleanup Paolo Abeni
2025-09-19 9:50 ` Geliang Tang
2025-09-19 12:36 ` Matthieu Baerts [this message]
2025-09-19 15:01 ` Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 08/12] mptcp: cleanup fallback data fin reception Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 09/12] mptcp: leverage the sk backlog for RX packet processing Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 10/12] mptcp: prevernt __mptcp_move_skbs() interfering with the fastpath Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 11/12] mptcp: borrow forward memory from subflow Paolo Abeni
2025-09-18 17:14 ` [PATCH mptcp-next v2 12/12] mptcp: make fallback backlog aware Paolo Abeni
2025-09-18 20:33 ` [PATCH mptcp-next v2 00/12] mptcp: receive path improvement MPTCP CI
2025-09-19 2:22 ` Geliang Tang
2025-09-19 6:54 ` Paolo Abeni
2025-09-19 7:30 ` Geliang Tang
2025-09-19 8:14 ` Matthieu Baerts
2025-09-19 13:11 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91594ac4-386b-4fbd-bc65-3bc302bf0e39@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.