From: Kukjin Kim <kgene@kernel.org>
To: 'Michal Suchanek' <hramrach@gmail.com>,
'Rob Herring' <robh+dt@kernel.org>,
'Pawel Moll' <pawel.moll@arm.com>,
'Mark Rutland' <mark.rutland@arm.com>,
'Ian Campbell' <ijc+devicetree@hellion.org.uk>,
'Kumar Gala' <galak@codeaurora.org>,
'Russell King' <linux@arm.linux.org.uk>,
'Kukjin Kim' <kgene@kernel.org>,
'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow
Date: Wed, 29 Jul 2015 09:57:29 +0900 [thread overview]
Message-ID: <041501d0c999$8af92f30$a0eb8d90$@kernel.org> (raw)
In-Reply-To: <e1952e8c102a3b7a7f3f79c759c44093e0d11dc7.1438073049.git.hramrach@gmail.com>
Michal Suchanek wrote:
>
> Although there is only one choice of chipselect it is necessary to
> specify it. The driver cannot claim the gpio otherwise.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
>From here ---8<--------8<-----------
> --
> - don't move unrelated line
> - use symbolic GPIO_ACTIVE_HIGH
to here ---8<--------8<-----------
should be added under the following '---'.
Please add some additional comments like above 'changes since previous version'
under the following '---' not '--', because all comments will be logged before
the '---' and I don't want to keep the changes basically.
Anyway, applied with removing above comments.
Thanks,
Kukjin
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index b7f4122..2d6a976 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -688,6 +688,7 @@
> status = "okay";
> samsung,spi-src-clk = <0>;
> num-cs = <1>;
> + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>;
> };
>
> &usbdrd_dwc3 {
> --
> 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow
Date: Wed, 29 Jul 2015 09:57:29 +0900 [thread overview]
Message-ID: <041501d0c999$8af92f30$a0eb8d90$@kernel.org> (raw)
In-Reply-To: <e1952e8c102a3b7a7f3f79c759c44093e0d11dc7.1438073049.git.hramrach@gmail.com>
Michal Suchanek wrote:
>
> Although there is only one choice of chipselect it is necessary to
> specify it. The driver cannot claim the gpio otherwise.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
>From here ---8<--------8<-----------
> --
> - don't move unrelated line
> - use symbolic GPIO_ACTIVE_HIGH
to here ---8<--------8<-----------
should be added under the following '---'.
Please add some additional comments like above 'changes since previous version'
under the following '---' not '--', because all comments will be logged before
the '---' and I don't want to keep the changes basically.
Anyway, applied with removing above comments.
Thanks,
Kukjin
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index b7f4122..2d6a976 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -688,6 +688,7 @@
> status = "okay";
> samsung,spi-src-clk = <0>;
> num-cs = <1>;
> + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>;
> };
>
> &usbdrd_dwc3 {
> --
> 2.1.4
next prev parent reply other threads:[~2015-07-29 0:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 20:11 [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow Michal Suchanek
2015-07-27 20:11 ` Michal Suchanek
2015-05-26 10:41 ` [PATCH v3] " Michal Suchanek
2015-07-28 8:45 ` Michal Suchanek
2015-07-29 0:57 ` Kukjin Kim [this message]
2015-07-29 0:57 ` Kukjin Kim
[not found] ` <a5054dfad3d48c582b062b0536125c9bcff41f31.1438027526.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-27 21:24 ` [PATCH v2] " Javier Martinez Canillas
2015-07-27 21:24 ` Javier Martinez Canillas
2015-07-27 21:24 ` Javier Martinez Canillas
2015-07-28 0:36 ` Krzysztof Kozlowski
2015-07-28 0:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='041501d0c999$8af92f30$a0eb8d90$@kernel.org' \
--to=kgene@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hramrach@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.