* [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-27 20:11 ` Michal Suchanek 0 siblings, 0 replies; 11+ messages in thread From: Michal Suchanek @ 2015-07-27 20:11 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Although there is only one choice of chipselect it is necessary to specify it. The driver cannot claim the gpio otherwise. Signed-off-by: Michal Suchanek <hramrach@gmail.com> -- v2 - don't move unrelated line --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index b7f4122..62be08a 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -688,6 +688,7 @@ status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; + cs-gpios = <&gpa2 5 0>; }; &usbdrd_dwc3 { -- 2.1.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-27 20:11 ` Michal Suchanek 0 siblings, 0 replies; 11+ messages in thread From: Michal Suchanek @ 2015-07-27 20:11 UTC (permalink / raw) To: linux-arm-kernel Although there is only one choice of chipselect it is necessary to specify it. The driver cannot claim the gpio otherwise. Signed-off-by: Michal Suchanek <hramrach@gmail.com> -- v2 - don't move unrelated line --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index b7f4122..62be08a 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -688,6 +688,7 @@ status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; + cs-gpios = <&gpa2 5 0>; }; &usbdrd_dwc3 { -- 2.1.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow 2015-07-27 20:11 ` Michal Suchanek @ 2015-07-28 8:45 ` Michal Suchanek -1 siblings, 0 replies; 11+ messages in thread From: Michal Suchanek @ 2015-05-26 10:41 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Although there is only one choice of chipselect it is necessary to specify it. The driver cannot claim the gpio otherwise. Signed-off-by: Michal Suchanek <hramrach@gmail.com> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> -- - don't move unrelated line - use symbolic GPIO_ACTIVE_HIGH --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index b7f4122..2d6a976 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -688,6 +688,7 @@ status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>; }; &usbdrd_dwc3 { -- 2.1.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-28 8:45 ` Michal Suchanek 0 siblings, 0 replies; 11+ messages in thread From: Michal Suchanek @ 2015-07-28 8:45 UTC (permalink / raw) To: linux-arm-kernel Although there is only one choice of chipselect it is necessary to specify it. The driver cannot claim the gpio otherwise. Signed-off-by: Michal Suchanek <hramrach@gmail.com> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> -- - don't move unrelated line - use symbolic GPIO_ACTIVE_HIGH --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index b7f4122..2d6a976 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -688,6 +688,7 @@ status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>; }; &usbdrd_dwc3 { -- 2.1.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow 2015-07-28 8:45 ` Michal Suchanek @ 2015-07-29 0:57 ` Kukjin Kim -1 siblings, 0 replies; 11+ messages in thread From: Kukjin Kim @ 2015-07-29 0:57 UTC (permalink / raw) To: 'Michal Suchanek', 'Rob Herring', 'Pawel Moll', 'Mark Rutland', 'Ian Campbell', 'Kumar Gala', 'Russell King', 'Kukjin Kim', 'Krzysztof Kozlowski', devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Michal Suchanek wrote: > > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >From here ---8<--------8<----------- > -- > - don't move unrelated line > - use symbolic GPIO_ACTIVE_HIGH to here ---8<--------8<----------- should be added under the following '---'. Please add some additional comments like above 'changes since previous version' under the following '---' not '--', because all comments will be logged before the '---' and I don't want to keep the changes basically. Anyway, applied with removing above comments. Thanks, Kukjin > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..2d6a976 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>; > }; > > &usbdrd_dwc3 { > -- > 2.1.4 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-29 0:57 ` Kukjin Kim 0 siblings, 0 replies; 11+ messages in thread From: Kukjin Kim @ 2015-07-29 0:57 UTC (permalink / raw) To: linux-arm-kernel Michal Suchanek wrote: > > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >From here ---8<--------8<----------- > -- > - don't move unrelated line > - use symbolic GPIO_ACTIVE_HIGH to here ---8<--------8<----------- should be added under the following '---'. Please add some additional comments like above 'changes since previous version' under the following '---' not '--', because all comments will be logged before the '---' and I don't want to keep the changes basically. Anyway, applied with removing above comments. Thanks, Kukjin > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..2d6a976 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>; > }; > > &usbdrd_dwc3 { > -- > 2.1.4 ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <a5054dfad3d48c582b062b0536125c9bcff41f31.1438027526.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow 2015-07-27 20:11 ` Michal Suchanek (?) @ 2015-07-27 21:24 ` Javier Martinez Canillas -1 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-07-27 21:24 UTC (permalink / raw) To: Michal Suchanek Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, Krzysztof Kozlowski, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Hello Michal, The patch looks good to me, just one small comment below. On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > -- > v2 > - don't move unrelated line > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..62be08a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or Krzysztof can fixup when applying it? > }; > > &usbdrd_dwc3 { > -- Acked-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-27 21:24 ` Javier Martinez Canillas 0 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-07-27 21:24 UTC (permalink / raw) To: Michal Suchanek Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, Krzysztof Kozlowski, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Linux Kernel Hello Michal, The patch looks good to me, just one small comment below. On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail.com> wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > > -- > v2 > - don't move unrelated line > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..62be08a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or Krzysztof can fixup when applying it? > }; > > &usbdrd_dwc3 { > -- Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-27 21:24 ` Javier Martinez Canillas 0 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-07-27 21:24 UTC (permalink / raw) To: linux-arm-kernel Hello Michal, The patch looks good to me, just one small comment below. On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail.com> wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > > -- > v2 > - don't move unrelated line > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..62be08a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or Krzysztof can fixup when applying it? > }; > > &usbdrd_dwc3 { > -- Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow 2015-07-27 21:24 ` Javier Martinez Canillas @ 2015-07-28 0:36 ` Krzysztof Kozlowski -1 siblings, 0 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2015-07-28 0:36 UTC (permalink / raw) To: Javier Martinez Canillas, Michal Suchanek Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Linux Kernel On 28.07.2015 06:24, Javier Martinez Canillas wrote: > Hello Michal, > > The patch looks good to me, just one small comment below. > > On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail.com> wrote: >> Although there is only one choice of chipselect it is necessary to >> specify it. The driver cannot claim the gpio otherwise. >> >> Signed-off-by: Michal Suchanek <hramrach@gmail.com> >> >> -- >> v2 >> - don't move unrelated line >> --- >> arch/arm/boot/dts/exynos5250-snow.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index b7f4122..62be08a 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -688,6 +688,7 @@ >> status = "okay"; >> samsung,spi-src-clk = <0>; >> num-cs = <1>; >> + cs-gpios = <&gpa2 5 0>; > > NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or > Krzysztof can fixup when applying it? > >> }; >> >> &usbdrd_dwc3 { >> -- > > Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Yes, the GPIO_ACTIVE_HIGH would be better. Can you re-spin the patch with this change and respective Acks? Including mine ack: Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow @ 2015-07-28 0:36 ` Krzysztof Kozlowski 0 siblings, 0 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2015-07-28 0:36 UTC (permalink / raw) To: linux-arm-kernel On 28.07.2015 06:24, Javier Martinez Canillas wrote: > Hello Michal, > > The patch looks good to me, just one small comment below. > > On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail.com> wrote: >> Although there is only one choice of chipselect it is necessary to >> specify it. The driver cannot claim the gpio otherwise. >> >> Signed-off-by: Michal Suchanek <hramrach@gmail.com> >> >> -- >> v2 >> - don't move unrelated line >> --- >> arch/arm/boot/dts/exynos5250-snow.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index b7f4122..62be08a 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -688,6 +688,7 @@ >> status = "okay"; >> samsung,spi-src-clk = <0>; >> num-cs = <1>; >> + cs-gpios = <&gpa2 5 0>; > > NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or > Krzysztof can fixup when applying it? > >> }; >> >> &usbdrd_dwc3 { >> -- > > Acked-by: Javier Martinez Canillas <javier@osg.samsung.com> Yes, the GPIO_ACTIVE_HIGH would be better. Can you re-spin the patch with this change and respective Acks? Including mine ack: Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-07-29 0:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27 20:11 [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow Michal Suchanek
2015-07-27 20:11 ` Michal Suchanek
2015-05-26 10:41 ` [PATCH v3] " Michal Suchanek
2015-07-28 8:45 ` Michal Suchanek
2015-07-29 0:57 ` Kukjin Kim
2015-07-29 0:57 ` Kukjin Kim
[not found] ` <a5054dfad3d48c582b062b0536125c9bcff41f31.1438027526.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-27 21:24 ` [PATCH v2] " Javier Martinez Canillas
2015-07-27 21:24 ` Javier Martinez Canillas
2015-07-27 21:24 ` Javier Martinez Canillas
2015-07-28 0:36 ` Krzysztof Kozlowski
2015-07-28 0:36 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.