All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Ben Collins" <bcollins@watter.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Andrew Hepp" <andrew.hepp@ahepp.dev>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v8 2/5] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
Date: Sat, 23 Aug 2025 11:09:23 -0500	[thread overview]
Message-ID: <04436186-254c-4e02-8536-5c9fd9c005c4@baylibre.com> (raw)
In-Reply-To: <f7089447-f164-406b-8e59-3bd3e8f94d59@baylibre.com>

On 8/23/25 11:06 AM, David Lechner wrote:
> On 8/22/25 8:23 AM, Ben Collins wrote:

...

>> +  - |
>> +    #include <dt-bindings/iio/temperature/thermocouple.h>
> 
> This header isn't used in this example.
> 
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        temperature-sensor@62 {
>> +            compatible = "microchip,mcp9601", "microchip,mcp9600";
>> +            reg = <0x62>;
>> +            interrupt-parent = <&gpio>;
>> +            interrupts = <22 IRQ_TYPE_EDGE_RISING>, <23 IRQ_TYPE_EDGE_RISING>;
>> +            interrupt-names = "open-circuit", "short-circuit";
>> +            vdd-supply = <&vdd>;
>> +            microchip,vsense;
>> +        };
>> +    };
>>
> 
> With that fixed:
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 

BTW, sometimes Jonathan is nice and fixes a one-line change like this
when applying patches, so don't rush off and send a v9 just quite yet
unless there are other bigger changes that need to be done anyway.

  reply	other threads:[~2025-08-23 16:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 13:23 [PATCH v8 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-22 13:23 ` [PATCH v8 1/5] dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type Ben Collins
2025-08-23 16:06   ` David Lechner
2025-08-22 13:23 ` [PATCH v8 2/5] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints Ben Collins
2025-08-23 16:06   ` David Lechner
2025-08-23 16:09     ` David Lechner [this message]
2025-08-22 13:23 ` [PATCH v8 3/5] iio: mcp9600: White space and fixed width cleanup Ben Collins
2025-08-22 13:23 ` [PATCH v8 4/5] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-22 15:57   ` Andy Shevchenko
2025-08-22 16:06     ` Ben Collins
2025-08-22 16:47       ` Andy Shevchenko
2025-08-25  9:36         ` Jonathan Cameron
2025-08-22 13:23 ` [PATCH v8 5/5] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-25  9:38 ` [PATCH v8 0/5] iio: mcp9600: Features and improvements Jonathan Cameron
2025-08-25 10:04   ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04436186-254c-4e02-8536-5c9fd9c005c4@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=andrew.hepp@ahepp.dev \
    --cc=andy@kernel.org \
    --cc=bcollins@watter.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.