Re: [PATCH v8 4/5] iio: mcp9600: Recognize chip id for mcp9601

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 22 Aug 2025 19:47:39 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Aug 22, 2025 at 7:07 PM Ben Collins <bcollins@watter.com> wrote:
> > > On Aug 22, 2025, at 11:57 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Fri, Aug 22, 2025 at 4:24 PM Ben Collins <bcollins@watter.com> wrote:  
> 
> ...
> 
> > >> +struct mcp9600_data {
> > >> +       struct i2c_client *client;
> > >> +};
> > >> +  
> > >  
> > >> -struct mcp9600_data {
> > >> -       struct i2c_client *client;
> > >> -};
> > >> -  
> > >
> > > Seems we discussed this. And my suggestion was to defer the change to
> > > when it will be needed.  
> >
> > And my response was that it’s needed in 5/5 where I add the mcp9600_config()
> > function. That function will need to be before mcp9600_channels[] in the
> > IIR patch series.
> >
> > So either I move mcp9600_data now, or I leave it and put mcp9600_config()
> > below it, and then in the IIR series I’ll have to move both up.
> >
> > Didn’t seem to make sense to move 30 lines of code later when I can move
> > 3 lines now.  
> 
> TBH, I have no strong preference, I leave this to Jonathan and other reviewers.
> 

Not significant enough to worry about. So I left it as is whilst applying.