* [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
@ 2019-06-04 11:37 Maharaja Kennadyrajan
2019-06-06 16:54 ` Kalle Valo
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Maharaja Kennadyrajan @ 2019-06-04 11:37 UTC (permalink / raw)
To: ath11k; +Cc: Maharaja Kennadyrajan
The rate mask value is changed from 0xff to oxffff (u8 to u32)
in the firmware for the legacy fixed rate and peer fixed rate
setting in the set bitrate command.
Hence this patch is fixing the same in the driver.
Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 6 +++---
drivers/net/wireless/ath/ath11k/wmi.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index cb0de8e2aa60..f490d7ccc2e2 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4454,7 +4454,7 @@ static int
ath11k_mac_get_single_legacy_rate(struct ath11k *ar,
enum nl80211_band band,
const struct cfg80211_bitrate_mask *mask,
- u8 *rate, u8 *nss)
+ u32 *rate, u8 *nss)
{
int rate_idx;
u16 bitrate;
@@ -4484,7 +4484,7 @@ ath11k_mac_get_single_legacy_rate(struct ath11k *ar,
}
static int ath11k_mac_set_fixed_rate_params(struct ath11k_vif *arvif,
- u8 rate, u8 nss, u8 sgi, u8 ldpc)
+ u32 rate, u8 nss, u8 sgi, u8 ldpc)
{
struct ath11k *ar = arvif->ar;
u32 vdev_param;
@@ -4584,7 +4584,7 @@ ath11k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
enum nl80211_band band;
const u8 *ht_mcs_mask;
const u16 *vht_mcs_mask;
- u8 rate;
+ u32 rate;
u8 nss;
u8 sgi;
u8 ldpc;
diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 366a136e53ac..fe89f761ccc3 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -4926,7 +4926,7 @@ enum wmi_ap_ps_peer_param {
#define WMI_CIPHER_AES_GMAC 0xa
/* Value to disable fixed rate setting */
-#define WMI_FIXED_RATE_NONE (0xff)
+#define WMI_FIXED_RATE_NONE (0xffff)
#define ATH11K_RC_VERSION_OFFSET 28
#define ATH11K_RC_PREAMBLE_OFFSET 8
--
2.21.0
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
2019-06-04 11:37 [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate Maharaja Kennadyrajan
@ 2019-06-06 16:54 ` Kalle Valo
[not found] ` <20190606165407.65AC460DAB@smtp.codeaurora.org>
2019-06-12 8:13 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-06-06 16:54 UTC (permalink / raw)
To: Maharaja Kennadyrajan; +Cc: ath11k
Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
> The rate mask value is changed from 0xff to oxffff (u8 to u32)
> in the firmware for the legacy fixed rate and peer fixed rate
> setting in the set bitrate command.
> Hence this patch is fixing the same in the driver.
>
> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
Is this backwards compatible change? I'm not convinced about that.
--
https://patchwork.kernel.org/patch/10974783/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <20190606165407.65AC460DAB@smtp.codeaurora.org>]
* Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
[not found] ` <20190606165407.65AC460DAB@smtp.codeaurora.org>
@ 2019-06-07 5:01 ` Maharaja Kennadyrajan
2019-06-07 5:05 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Maharaja Kennadyrajan @ 2019-06-07 5:01 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k
On 2019-06-06 10:24 pm, Kalle Valo wrote:
> Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
>
>> The rate mask value is changed from 0xff to oxffff (u8 to u32)
>> in the firmware for the legacy fixed rate and peer fixed rate
>> setting in the set bitrate command.
>> Hence this patch is fixing the same in the driver.
>>
>> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
>
> Is this backwards compatible change? I'm not convinced about that.
[Maha]: It won't break the backward compatibility as firmware is taking
care of it.
Firmware is using 0xffff as mask value from the beginning and this
change is not added
recently in the firmware.
--
Regards,
Maha
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
2019-06-07 5:01 ` Maharaja Kennadyrajan
@ 2019-06-07 5:05 ` Kalle Valo
2019-06-07 7:48 ` Maharaja Kennadyrajan
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2019-06-07 5:05 UTC (permalink / raw)
To: Maharaja Kennadyrajan; +Cc: ath11k
Maharaja Kennadyrajan <mkenna@codeaurora.org> writes:
> On 2019-06-06 10:24 pm, Kalle Valo wrote:
>> Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
>>
>>> The rate mask value is changed from 0xff to oxffff (u8 to u32)
>>> in the firmware for the legacy fixed rate and peer fixed rate
>>> setting in the set bitrate command.
>>> Hence this patch is fixing the same in the driver.
>>>
>>> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
>>
>> Is this backwards compatible change? I'm not convinced about that.
>
> [Maha]: It won't break the backward compatibility as firmware is
> taking care of it. Firmware is using 0xffff as mask value from the
> beginning and this change is not added recently in the firmware.
Good, thanks for the clarification.
--
Kalle Valo
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
2019-06-07 5:05 ` Kalle Valo
@ 2019-06-07 7:48 ` Maharaja Kennadyrajan
0 siblings, 0 replies; 6+ messages in thread
From: Maharaja Kennadyrajan @ 2019-06-07 7:48 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k
On 2019-06-07 10:35 am, Kalle Valo wrote:
> Maharaja Kennadyrajan <mkenna@codeaurora.org> writes:
>
>> On 2019-06-06 10:24 pm, Kalle Valo wrote:
>>> Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
>>>
>>>> The rate mask value is changed from 0xff to oxffff (u8 to u32)
>>>> in the firmware for the legacy fixed rate and peer fixed rate
>>>> setting in the set bitrate command.
>>>> Hence this patch is fixing the same in the driver.
>>>>
>>>> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
>>>
>>> Is this backwards compatible change? I'm not convinced about that.
>>
>> [Maha]: It won't break the backward compatibility as firmware is
>> taking care of it. Firmware is using 0xffff as mask value from the
>> beginning and this change is not added recently in the firmware.
>
> Good, thanks for the clarification.
[Maha]: Thanks, please apply this is patch in ath.git
--
Regards,
Maha
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate
2019-06-04 11:37 [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate Maharaja Kennadyrajan
2019-06-06 16:54 ` Kalle Valo
[not found] ` <20190606165407.65AC460DAB@smtp.codeaurora.org>
@ 2019-06-12 8:13 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-06-12 8:13 UTC (permalink / raw)
To: Maharaja Kennadyrajan; +Cc: ath11k
Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
> The rate mask value is changed from 0xff to oxffff (u8 to u32)
> in the firmware for the legacy fixed rate and peer fixed rate
> setting in the set bitrate command.
> Hence this patch is fixing the same in the driver.
>
> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath11k-bringup branch of ath.git, thanks.
b23bdcc21752 ath11k: Fix the rate mask value for legacy and peer fixed rate
--
https://patchwork.kernel.org/patch/10974783/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-12 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 11:37 [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate Maharaja Kennadyrajan
2019-06-06 16:54 ` Kalle Valo
[not found] ` <20190606165407.65AC460DAB@smtp.codeaurora.org>
2019-06-07 5:01 ` Maharaja Kennadyrajan
2019-06-07 5:05 ` Kalle Valo
2019-06-07 7:48 ` Maharaja Kennadyrajan
2019-06-12 8:13 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.