All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, sroland@vmware.com,
	zackr@vmware.com
Cc: intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	linux-graphics-maintainer@vmware.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4 3/6] drm/i915/gt: Remove references to struct drm_device.pdev
Date: Mon, 18 Jan 2021 15:51:58 +0100	[thread overview]
Message-ID: <07aa5189-e024-7596-67f9-3c4acfea4beb@suse.de> (raw)
In-Reply-To: <161097709046.27171.15246982051954461820@build.alporthouse.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 865 bytes --]

Hi

Am 18.01.21 um 14:38 schrieb Chris Wilson:
> Quoting Thomas Zimmermann (2021-01-18 13:14:17)
>> Using struct drm_device.pdev is deprecated. Convert i915 to struct
>> drm_device.dev. No functional changes.
> 
> This needs to be before or in the previous patch, as that patch removed
> assignment of i915->drm.pdev.
> 
> Or the removal of the assignment moved to the end as a separate patch.
> That makes more sense.

Makes sense. The patches can be reordered easily. There was some 
discussion on irc about how the i915 patches first need a merge of the 
i915 tree to the gvt tree, or something like that.

Best regards
Thomas

> -Chris
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, sroland@vmware.com,
	zackr@vmware.com
Cc: intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	linux-graphics-maintainer@vmware.com,
	dri-devel@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v4 3/6] drm/i915/gt: Remove references to struct drm_device.pdev
Date: Mon, 18 Jan 2021 15:51:58 +0100	[thread overview]
Message-ID: <07aa5189-e024-7596-67f9-3c4acfea4beb@suse.de> (raw)
In-Reply-To: <161097709046.27171.15246982051954461820@build.alporthouse.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 865 bytes --]

Hi

Am 18.01.21 um 14:38 schrieb Chris Wilson:
> Quoting Thomas Zimmermann (2021-01-18 13:14:17)
>> Using struct drm_device.pdev is deprecated. Convert i915 to struct
>> drm_device.dev. No functional changes.
> 
> This needs to be before or in the previous patch, as that patch removed
> assignment of i915->drm.pdev.
> 
> Or the removal of the assignment moved to the end as a separate patch.
> That makes more sense.

Makes sense. The patches can be reordered easily. There was some 
discussion on irc about how the i915 patches first need a merge of the 
i915 tree to the gvt tree, or something like that.

Best regards
Thomas

> -Chris
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-01-18 14:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 13:14 [Intel-gfx] [PATCH v4 0/6] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 1/6] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 13:30   ` [Intel-gfx] " Daniel Vetter
2021-01-18 13:30     ` Daniel Vetter
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 2/6] drm/i915: Remove references to struct drm_device.pdev Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 3/6] drm/i915/gt: " Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 13:38   ` [Intel-gfx] " Chris Wilson
2021-01-18 13:38     ` Chris Wilson
2021-01-18 14:51     ` Thomas Zimmermann [this message]
2021-01-18 14:51       ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 4/6] drm/i915/gvt: " Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 5/6] drm/vmwgfx: Remove reference " Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 19:33   ` [Intel-gfx] " Zack Rusin
2021-01-18 19:33     ` Zack Rusin
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 6/6] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann
2021-01-18 13:14   ` Thomas Zimmermann
2021-01-18 18:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Move struct drm_device.pdev to legacy (rev4) Patchwork
2021-01-19  0:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-19 14:51 ` [Intel-gfx] [PATCH v4 0/6] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-19 14:51   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07aa5189-e024-7596-67f9-3c4acfea4beb@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=sroland@vmware.com \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.