From: Zack Rusin <zackr@vmware.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Roland Scheidegger <sroland@vmware.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Martin Krastev <krastevm@vmware.com>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v4 5/6] drm/vmwgfx: Remove reference to struct drm_device.pdev
Date: Mon, 18 Jan 2021 19:33:09 +0000 [thread overview]
Message-ID: <4AE40A60-7DE8-4018-9CDB-FA4EE4F378CB@vmware.com> (raw)
In-Reply-To: <20210118131420.15874-6-tzimmermann@suse.de>
> On Jan 18, 2021, at 08:14, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Using struct drm_device.pdev is deprecated in favor of drm_device.dev.
> The reference to the field was reintroduced during a rebase.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 9703bb329206 ("drm/vmwgfx: Switch to a managed drm device")
> Cc: Zack Rusin <zackr@vmware.com>
> Cc: Martin Krastev <krastevm@vmware.com>
> Cc: Roland Scheidegger <sroland@vmware.com>
> Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 8c3eb00e8b54..545b83e338fc 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -1524,7 +1524,6 @@ static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (IS_ERR(vmw))
> return PTR_ERR(vmw);
>
> - vmw->drm.pdev = pdev;
> pci_set_drvdata(pdev, &vmw->drm);
>
> ret = vmw_driver_load(vmw, ent->device);
Ah, sorry about that. Looks good.
Reviewed-by: Zack Rusin <zackr@vmware.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Zack Rusin <zackr@vmware.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Roland Scheidegger <sroland@vmware.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Martin Krastev <krastevm@vmware.com>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v4 5/6] drm/vmwgfx: Remove reference to struct drm_device.pdev
Date: Mon, 18 Jan 2021 19:33:09 +0000 [thread overview]
Message-ID: <4AE40A60-7DE8-4018-9CDB-FA4EE4F378CB@vmware.com> (raw)
In-Reply-To: <20210118131420.15874-6-tzimmermann@suse.de>
> On Jan 18, 2021, at 08:14, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Using struct drm_device.pdev is deprecated in favor of drm_device.dev.
> The reference to the field was reintroduced during a rebase.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 9703bb329206 ("drm/vmwgfx: Switch to a managed drm device")
> Cc: Zack Rusin <zackr@vmware.com>
> Cc: Martin Krastev <krastevm@vmware.com>
> Cc: Roland Scheidegger <sroland@vmware.com>
> Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 8c3eb00e8b54..545b83e338fc 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -1524,7 +1524,6 @@ static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (IS_ERR(vmw))
> return PTR_ERR(vmw);
>
> - vmw->drm.pdev = pdev;
> pci_set_drvdata(pdev, &vmw->drm);
>
> ret = vmw_driver_load(vmw, ent->device);
Ah, sorry about that. Looks good.
Reviewed-by: Zack Rusin <zackr@vmware.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-18 19:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:14 [Intel-gfx] [PATCH v4 0/6] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 1/6] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:30 ` [Intel-gfx] " Daniel Vetter
2021-01-18 13:30 ` Daniel Vetter
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 2/6] drm/i915: Remove references to struct drm_device.pdev Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 3/6] drm/i915/gt: " Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:38 ` [Intel-gfx] " Chris Wilson
2021-01-18 13:38 ` Chris Wilson
2021-01-18 14:51 ` [Intel-gfx] " Thomas Zimmermann
2021-01-18 14:51 ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 4/6] drm/i915/gvt: " Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 5/6] drm/vmwgfx: Remove reference " Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 19:33 ` Zack Rusin [this message]
2021-01-18 19:33 ` Zack Rusin
2021-01-18 13:14 ` [Intel-gfx] [PATCH v4 6/6] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann
2021-01-18 13:14 ` Thomas Zimmermann
2021-01-18 18:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Move struct drm_device.pdev to legacy (rev4) Patchwork
2021-01-19 0:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-19 14:51 ` [Intel-gfx] [PATCH v4 0/6] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-19 14:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE40A60-7DE8-4018-9CDB-FA4EE4F378CB@vmware.com \
--to=zackr@vmware.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=krastevm@vmware.com \
--cc=sroland@vmware.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.