Re: [PATCH v4 15/25] xen/riscv: introduce per-vCPU IMSIC state

[Jan Beulich <jbeulich@suse.com>]

On 26.06.2026 17:46, Oleksii Kurochko wrote:
> @@ -312,6 +318,35 @@ static int imsic_parse_node(const struct dt_device_node *node,
>      return 0;
>  }
>  
> +int vcpu_imsic_init(struct vcpu *v)
> +{
> +    struct vimsic_state *imsic_state;
> +
> +    /* Allocate IMSIC context */
> +    imsic_state = xvzalloc(struct vimsic_state);
> +    if ( !imsic_state )
> +        return -ENOMEM;
> +
> +    v->arch.vimsic_state = imsic_state;

May I suggest that you make the pointer globally visible only after ...

> +    /* Setup IMSIC context  */
> +    rwlock_init(&imsic_state->vsfile_lock);
> +
> +    /*
> +     * xvzalloc() already cleared the context, so guest_file_id == 0, i.e. the
> +     * always-available s/w IMSIC VS-file. Only vsfile_pcpu needs an explicit
> +     * initializer as its s/w VS-file value is NR_CPUS rather than 0.
> +     */
> +    imsic_state->vsfile_pcpu = NR_CPUS;

... having set up fields? Then:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan