Re: [PATCH v4 08/25] xen/riscv: introduce guest riscv,isa string

[Oleksii Kurochko <oleksii.kurochko@gmail.com>]

On 7/1/26 8:22 AM, Jan Beulich wrote:
>>>> @@ -94,6 +95,9 @@ struct arch_domain {
>>>>        struct p2m_domain p2m;
>>>>    
>>>>        struct paging_domain paging;
>>>> +
>>>> +    DECLARE_BITMAP(isa, RISCV_ISA_EXT_MAX);
>>>> +    char *isa_str;
>>>>    };
>>> Why is it again that both the bitmap and its string representation need
>>> storing? In the end they provide two different sources of truth, as there's
>>> no guarantee that they'll remain in sync.
>> isa_str is needed to guest device tree to tell which extensions are
>> supported.
> Sure, but does that need storing over the lifetime of the domain? 

Considering my answer to you last question here ... then there is no 
such need.

Can't
> that string be allocated, built, used, and then freed while DT is being
> built? 

Agree, it could be done in this way.

Would that string be used at all for toolstack-created domains?

... No, it won't. This string will be created by toolstack. So it could 
really be dropped from arch_domain.

Thasnk.

~ Oleksii