Re: [PATCH v4 18/25] xen/riscv: introduce (de)initialization helpers for vINTC

[Oleksii Kurochko <oleksii.kurochko@gmail.com>]

On 6/29/26 5:07 PM, Jan Beulich wrote:
> On 26.06.2026 17:46, Oleksii Kurochko wrote:
>> Add common helpers domain_vintc_init() and domain_vintc_deinit() to
>> allocate and deallocate a virtual interrupt controller (vINTC)
>> structure and initialize basic virtual interrupt controller registers.
>>
>> domain_vintc_deinit() isn't called at the moment as arch_domain_destroy()
>> is implemented as stub at the moment.
>>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks.

> with one more suggestion:
> 
>> @@ -83,3 +84,37 @@ int __init make_intc_domU_node(struct kernel_info *kinfo)
>>   
>>       return vintc->init_ops->make_domu_dt_node(kinfo);
>>   }
>> +
>> +int domain_vintc_init(struct domain *d)
>> +{
>> +    int ret = -EOPNOTSUPP;
>> +    const enum intc_variant variant = intc_hw_ops->info->hw_variant;
>> +
>> +    switch ( variant )
>> +    {
>> +    case INTC_APLIC:
>> +        ret = domain_vaplic_init(d);
>> +        break;
>> +
>> +    default:
>> +        printk("vintc (variant:%d) isn't implemented\n", variant);
> 
> printk_once() maybe?

It makes sense. I will apply your suggestions.

~ Oleksii