From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: liuqiangneo@163.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Qiang Liu <liuqiang@kylinos.cn>
Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code
Date: Fri, 5 Sep 2025 12:15:38 +0100 [thread overview]
Message-ID: <07eafea5-294d-42b4-bfd8-27ca32e642a2@linux.dev> (raw)
In-Reply-To: <20250905025519.58196-1-liuqiangneo@163.com>
On 05/09/2025 03:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
LGTM,
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
WARNING: multiple messages have this Message-ID (diff)
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: liuqiangneo@163.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Qiang Liu <liuqiang@kylinos.cn>
Subject: Re: [PATCH] ixgbe: Remove self-assignment code
Date: Fri, 5 Sep 2025 12:15:38 +0100 [thread overview]
Message-ID: <07eafea5-294d-42b4-bfd8-27ca32e642a2@linux.dev> (raw)
In-Reply-To: <20250905025519.58196-1-liuqiangneo@163.com>
On 05/09/2025 03:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
LGTM,
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2025-09-05 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 2:55 [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code liuqiangneo
2025-09-05 2:55 ` liuqiangneo
2025-09-05 11:15 ` Vadim Fedorenko [this message]
2025-09-05 11:15 ` Vadim Fedorenko
2025-09-05 11:38 ` [Intel-wired-lan] " Przemek Kitszel
2025-09-05 11:38 ` Przemek Kitszel
2025-09-05 20:05 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-05 20:05 ` Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07eafea5-294d-42b4-bfd8-27ca32e642a2@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuqiang@kylinos.cn \
--cc=liuqiangneo@163.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.