* [PATCH] ixgbe: Remove self-assignment code
@ 2025-09-05 2:55 ` liuqiangneo
0 siblings, 0 replies; 8+ messages in thread
From: liuqiangneo @ 2025-09-05 2:55 UTC (permalink / raw)
To: anthony.l.nguyen, przemyslaw.kitszel
Cc: intel-wired-lan, netdev, linux-kernel, Qiang Liu
From: Qiang Liu <liuqiang@kylinos.cn>
After obtaining the register value via raw_desc,
redundant self-assignment operations can be removed.
Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
index bfeef5b0b99d..6efedf04a963 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
@@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
/* Read sync Admin Command response */
if ((hicr & IXGBE_PF_HICR_SV)) {
- for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
+ for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
- raw_desc[i] = raw_desc[i];
- }
}
/* Read async Admin Command response */
if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
- for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
+ for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
- raw_desc[i] = raw_desc[i];
- }
}
/* Handle timeout and invalid state of HICR register */
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code
2025-09-05 2:55 ` liuqiangneo
@ 2025-09-05 11:15 ` Vadim Fedorenko
-1 siblings, 0 replies; 8+ messages in thread
From: Vadim Fedorenko @ 2025-09-05 11:15 UTC (permalink / raw)
To: liuqiangneo, anthony.l.nguyen, przemyslaw.kitszel
Cc: intel-wired-lan, netdev, linux-kernel, Qiang Liu
On 05/09/2025 03:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
LGTM,
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ixgbe: Remove self-assignment code
@ 2025-09-05 11:15 ` Vadim Fedorenko
0 siblings, 0 replies; 8+ messages in thread
From: Vadim Fedorenko @ 2025-09-05 11:15 UTC (permalink / raw)
To: liuqiangneo, anthony.l.nguyen, przemyslaw.kitszel
Cc: intel-wired-lan, netdev, linux-kernel, Qiang Liu
On 05/09/2025 03:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
LGTM,
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code
2025-09-05 2:55 ` liuqiangneo
@ 2025-09-05 11:38 ` Przemek Kitszel
-1 siblings, 0 replies; 8+ messages in thread
From: Przemek Kitszel @ 2025-09-05 11:38 UTC (permalink / raw)
To: liuqiangneo, anthony.l.nguyen
Cc: intel-wired-lan, netdev, linux-kernel, Qiang Liu,
Dheeraj Reddy Jonnalagadda, Michal Swiatkowski, Piotr Kwapulinski
On 9/5/25 04:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
this, obviously pointless in current form, code is a remnant stripping
down our OOT driver, during which we have lost cpu_to_le32() call
there were already an attempt to fix that:
https://patchew.org/linux/20250115034117.172999-1-dheeraj.linuxdev@gmail.com/
but it got stuck on on some sparse warnings, and discussion weather to
go with full conversion (of whole driver, not only the two obviously
missing points) or not, and there were no final action taken
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ixgbe: Remove self-assignment code
@ 2025-09-05 11:38 ` Przemek Kitszel
0 siblings, 0 replies; 8+ messages in thread
From: Przemek Kitszel @ 2025-09-05 11:38 UTC (permalink / raw)
To: liuqiangneo, anthony.l.nguyen
Cc: intel-wired-lan, netdev, linux-kernel, Qiang Liu,
Dheeraj Reddy Jonnalagadda, Michal Swiatkowski, Piotr Kwapulinski
On 9/5/25 04:55, liuqiangneo@163.com wrote:
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
this, obviously pointless in current form, code is a remnant stripping
down our OOT driver, during which we have lost cpu_to_le32() call
there were already an attempt to fix that:
https://patchew.org/linux/20250115034117.172999-1-dheeraj.linuxdev@gmail.com/
but it got stuck on on some sparse warnings, and discussion weather to
go with full conversion (of whole driver, not only the two obviously
missing points) or not, and there were no final action taken
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Handle timeout and invalid state of HICR register */
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code
2025-09-05 2:55 ` liuqiangneo
@ 2025-09-05 20:05 ` Loktionov, Aleksandr
-1 siblings, 0 replies; 8+ messages in thread
From: Loktionov, Aleksandr @ 2025-09-05 20:05 UTC (permalink / raw)
To: liuqiangneo@163.com, Nguyen, Anthony L, Kitszel, Przemyslaw
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Qiang Liu
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of liuqiangneo@163.com
> Sent: Friday, September 5, 2025 4:55 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Qiang Liu <liuqiang@kylinos.cn>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment
> code
>
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct
> ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
Can you refactor it to use IXGBE_READ_REG_ARRAY(hw, REG, i)?
this can greatly improve readability!
> }
>
> /* Handle timeout and invalid state of HICR register */
> --
> 2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment code
@ 2025-09-05 20:05 ` Loktionov, Aleksandr
0 siblings, 0 replies; 8+ messages in thread
From: Loktionov, Aleksandr @ 2025-09-05 20:05 UTC (permalink / raw)
To: liuqiangneo@163.com, Nguyen, Anthony L, Kitszel, Przemyslaw
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Qiang Liu
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of liuqiangneo@163.com
> Sent: Friday, September 5, 2025 4:55 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Qiang Liu <liuqiang@kylinos.cn>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment
> code
>
> From: Qiang Liu <liuqiang@kylinos.cn>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct
> ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
Can you refactor it to use IXGBE_READ_REG_ARRAY(hw, REG, i)?
this can greatly improve readability!
> }
>
> /* Handle timeout and invalid state of HICR register */
> --
> 2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread