From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>, nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH 4/6] iio: buffer-dma: Fix coding style complains
Date: Thu, 04 Dec 2025 11:25:12 +0000 [thread overview]
Message-ID: <0824e2b0d4c29de9f4bba37dbf60dbba97bcd789.camel@gmail.com> (raw)
In-Reply-To: <aTBlg2rW0rrjHh73@smile.fi.intel.com>
On Wed, 2025-12-03 at 18:29 +0200, Andy Shevchenko wrote:
> On Wed, Dec 03, 2025 at 03:11:39PM +0000, Nuno Sá via B4 Relay wrote:
>
> > Just making sure checkpatch is happy. No functional change intended.
>
> ...
>
> > -static struct iio_dma_buffer_block *iio_dma_buffer_alloc_block(
> > - struct iio_dma_buffer_queue *queue, size_t size, bool fileio)
> > +static struct iio_dma_buffer_block *iio_dma_buffer_alloc_block(struct iio_dma_buffer_queue
> > *queue,
> > + size_t size,
> > + bool fileio)
>
> What about 80 rule?
>
This falls in the bucket where readability is hurt. At least IMHO, so that's why I
did it this way. If Jonathan disagrees, I'll of course change it to the below style.
> static struct iio_dma_buffer_block *
> iio_dma_buffer_alloc_block(struct iio_dma_buffer_queue *queue, size_t size,
> bool fileio)
>
> (And personally I think that in 2025 we should grow up and forget about this
> and move on to 100, but... not a maintainer here :-)
FWIW, Agreed! (And that is what I do for all the out of tree stuff :))
- Nuno Sá
next prev parent reply other threads:[~2025-12-04 11:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 15:11 [PATCH 0/6] iio: buffer-dma: Minor cleanups and improvements Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 15:11 ` [PATCH 1/6] iio: buffer-dma: use lockdep instead of WARN() Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:20 ` Andy Shevchenko
2025-12-04 11:20 ` Nuno Sá
2025-12-03 15:11 ` [PATCH 2/6] iio: buffer-dma: Use the cleanup.h API Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:23 ` Andy Shevchenko
2025-12-06 21:12 ` Jonathan Cameron
2025-12-03 15:11 ` [PATCH 3/6] iio: buffer-dma: Turn iio_dma_buffer_init() void Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:34 ` Andy Shevchenko
2025-12-19 15:03 ` Nuno Sá
2025-12-27 14:02 ` Andy Shevchenko
2026-01-02 10:25 ` Nuno Sá
2026-01-02 12:42 ` Andy Shevchenko
2025-12-03 15:11 ` [PATCH 4/6] iio: buffer-dma: Fix coding style complains Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:29 ` Andy Shevchenko
2025-12-04 11:25 ` Nuno Sá [this message]
2025-12-06 21:09 ` Jonathan Cameron
2025-12-03 15:11 ` [PATCH 5/6] iio: buffer-dmaengine: Use the cleanup.h API Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 15:11 ` [PATCH 6/6] iio: buffer-dmaengine: Fix coding style complains Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:31 ` Andy Shevchenko
2025-12-03 16:33 ` Andy Shevchenko
2025-12-04 11:21 ` Nuno Sá
2025-12-04 11:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0824e2b0d4c29de9f4bba37dbf60dbba97bcd789.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.