From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>, nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH 1/6] iio: buffer-dma: use lockdep instead of WARN()
Date: Thu, 04 Dec 2025 11:20:07 +0000 [thread overview]
Message-ID: <e1225ea028cdaca2430a77f777a93ed0c99539c7.camel@gmail.com> (raw)
In-Reply-To: <aTBjRQ-FLZizHZn7@smile.fi.intel.com>
On Wed, 2025-12-03 at 18:20 +0200, Andy Shevchenko wrote:
> On Wed, Dec 03, 2025 at 03:11:36PM +0000, Nuno Sá via B4 Relay wrote:
> >
> > As documented, WARN() should be used with care given that it can panic
> > running kernels (depending on command line options). So, instead of
> > using it to make sure a lock is held, use the annotations we already
> > have in the kernel for the very same reason.
>
> Which also will be a WARN :-)
>
Obviously :facepalm:
> I believe the main value is a bit different here, i.e. to have code being
> annotated with the existing infrastructure.
>
> In any case I support this change
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
next prev parent reply other threads:[~2025-12-04 11:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 15:11 [PATCH 0/6] iio: buffer-dma: Minor cleanups and improvements Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 15:11 ` [PATCH 1/6] iio: buffer-dma: use lockdep instead of WARN() Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:20 ` Andy Shevchenko
2025-12-04 11:20 ` Nuno Sá [this message]
2025-12-03 15:11 ` [PATCH 2/6] iio: buffer-dma: Use the cleanup.h API Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:23 ` Andy Shevchenko
2025-12-06 21:12 ` Jonathan Cameron
2025-12-03 15:11 ` [PATCH 3/6] iio: buffer-dma: Turn iio_dma_buffer_init() void Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:34 ` Andy Shevchenko
2025-12-19 15:03 ` Nuno Sá
2025-12-27 14:02 ` Andy Shevchenko
2026-01-02 10:25 ` Nuno Sá
2026-01-02 12:42 ` Andy Shevchenko
2025-12-03 15:11 ` [PATCH 4/6] iio: buffer-dma: Fix coding style complains Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:29 ` Andy Shevchenko
2025-12-04 11:25 ` Nuno Sá
2025-12-06 21:09 ` Jonathan Cameron
2025-12-03 15:11 ` [PATCH 5/6] iio: buffer-dmaengine: Use the cleanup.h API Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 15:11 ` [PATCH 6/6] iio: buffer-dmaengine: Fix coding style complains Nuno Sá
2025-12-03 15:11 ` Nuno Sá via B4 Relay
2025-12-03 16:31 ` Andy Shevchenko
2025-12-03 16:33 ` Andy Shevchenko
2025-12-04 11:21 ` Nuno Sá
2025-12-04 11:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1225ea028cdaca2430a77f777a93ed0c99539c7.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.