All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: SeongJae Park <sjpark@amazon.com>,
	axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com
Cc: SeongJae Park <sjpark@amazon.de>,
	pdurrant@amazon.com, sj38.park@gmail.com,
	xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 2/5] xenbus/backend: Protect xenbus callback with lock
Date: Fri, 20 Dec 2019 12:42:11 +0100	[thread overview]
Message-ID: <08256095-3b19-8041-9ceb-e9caa77ed4c5@suse.com> (raw)
In-Reply-To: <20191218183718.31719-3-sjpark@amazon.com>

On 18.12.19 19:37, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
> 
> A driver's 'reclaim_memory' callback can race with 'probe' or 'remove'
> because it will be called whenever memory pressure is detected.  To
> avoid such race, this commit embeds a spinlock in each 'xenbus_device'
> and make 'xenbus' to hold the lock while the corresponded callbacks are
> running.
> 
> Signed-off-by: SeongJae Park <sjpark@amazon.de>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

WARNING: multiple messages have this Message-ID (diff)
From: "Jürgen Groß" <jgross@suse.com>
To: SeongJae Park <sjpark@amazon.com>,
	axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com
Cc: linux-block@vger.kernel.org, pdurrant@amazon.com,
	SeongJae Park <sjpark@amazon.de>,
	linux-kernel@vger.kernel.org, sj38.park@gmail.com,
	xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v13 2/5] xenbus/backend: Protect xenbus callback with lock
Date: Fri, 20 Dec 2019 12:42:11 +0100	[thread overview]
Message-ID: <08256095-3b19-8041-9ceb-e9caa77ed4c5@suse.com> (raw)
In-Reply-To: <20191218183718.31719-3-sjpark@amazon.com>

On 18.12.19 19:37, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
> 
> A driver's 'reclaim_memory' callback can race with 'probe' or 'remove'
> because it will be called whenever memory pressure is detected.  To
> avoid such race, this commit embeds a spinlock in each 'xenbus_device'
> and make 'xenbus' to hold the lock while the corresponded callbacks are
> running.
> 
> Signed-off-by: SeongJae Park <sjpark@amazon.de>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-12-20 11:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 18:37 [PATCH v13 0/5] xenbus/backend: Add memory pressure handler callback SeongJae Park
2019-12-18 18:37 ` [Xen-devel] " SeongJae Park
2019-12-18 18:37 ` [PATCH v13 1/5] " SeongJae Park
2019-12-18 18:37   ` [Xen-devel] " SeongJae Park
2019-12-18 18:37 ` [PATCH v13 2/5] xenbus/backend: Protect xenbus callback with lock SeongJae Park
2019-12-18 18:37   ` [Xen-devel] " SeongJae Park
2019-12-20 11:42   ` Jürgen Groß [this message]
2019-12-20 11:42     ` Jürgen Groß
2019-12-18 18:37 ` [PATCH v13 3/5] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-18 18:37   ` [Xen-devel] " SeongJae Park
2020-01-03  7:54   ` SeongJae Park
2020-01-03  7:54     ` SeongJae Park
2020-01-08 12:40   ` Roger Pau Monné
2020-01-08 12:40     ` [Xen-devel] " Roger Pau Monné
2019-12-18 18:37 ` [PATCH v13 4/5] xen/blkback: Remove unnecessary static variable name prefixes SeongJae Park
2019-12-18 18:37   ` [Xen-devel] " SeongJae Park
2019-12-18 18:38 ` SeongJae Park
2019-12-18 18:38   ` [Xen-devel] " SeongJae Park
2019-12-18 18:39 ` [PATCH v13 5/5] xen/blkback: Consistently insert one empty line between functions SeongJae Park
2019-12-18 18:39   ` [Xen-devel] " SeongJae Park
2020-01-13  9:49 ` [Xen-devel] [PATCH v13 0/5] xenbus/backend: Add memory pressure handler callback SeongJae Park
2020-01-13  9:49   ` SeongJae Park
2020-01-13  9:55   ` Roger Pau Monné
2020-01-13  9:55     ` Roger Pau Monné
2020-01-13  9:59     ` SeongJae Park
2020-01-13  9:59       ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08256095-3b19-8041-9ceb-e9caa77ed4c5@suse.com \
    --to=jgross@suse.com \
    --cc=axboe@kernel.dk \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pdurrant@amazon.com \
    --cc=roger.pau@citrix.com \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.com \
    --cc=sjpark@amazon.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.