From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Moises Cardona <moisesmcardona@gmail.com>, cezary.rojewski@intel.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com,
tiwai@suse.com, ranjani.sridharan@linux.intel.com,
liam.r.girdwood@linux.intel.com, hdegoede@redhat.com,
broonie@kernel.org, akihiko.odaki@gmail.com,
yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
Date: Tue, 13 Dec 2022 13:04:41 -0600 [thread overview]
Message-ID: <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com> (raw)
In-Reply-To: <20221213173550.1567875-1-moisesmcardona@gmail.com>
On 12/13/22 11:35, Moises Cardona wrote:
> The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
> with the exception of the added SIM Card Slot.
> Therefore, I'm submitting this patch which properly initializes the audio
> and enables the headphone jack to work, just like it does in the
> HP Stream 7.
>
> Signed-off-by: Moises Cardona <moisesmcardona@gmail.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index fb9d9e271845..1d964b1ceff4 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_SSP0_AIF1 |
> BYT_RT5640_MCLK_EN),
> },
> + { /* HP Stream 8 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"),
> + },
> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> + BYT_RT5640_MONO_SPEAKER |
> + BYT_RT5640_JD_NOT_INV |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> { /* I.T.Works TW891 */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Moises Cardona <moisesmcardona@gmail.com>, cezary.rojewski@intel.com
Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
hdegoede@redhat.com, oder_chiou@realtek.com,
akihiko.odaki@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
Date: Tue, 13 Dec 2022 13:04:41 -0600 [thread overview]
Message-ID: <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com> (raw)
In-Reply-To: <20221213173550.1567875-1-moisesmcardona@gmail.com>
On 12/13/22 11:35, Moises Cardona wrote:
> The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
> with the exception of the added SIM Card Slot.
> Therefore, I'm submitting this patch which properly initializes the audio
> and enables the headphone jack to work, just like it does in the
> HP Stream 7.
>
> Signed-off-by: Moises Cardona <moisesmcardona@gmail.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index fb9d9e271845..1d964b1ceff4 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_SSP0_AIF1 |
> BYT_RT5640_MCLK_EN),
> },
> + { /* HP Stream 8 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"),
> + },
> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> + BYT_RT5640_MONO_SPEAKER |
> + BYT_RT5640_JD_NOT_INV |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> { /* I.T.Works TW891 */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
next prev parent reply other threads:[~2022-12-14 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 17:35 [PATCH] Add HP Stream 8 to bytcr_rt5640.c Moises Cardona
2022-12-13 19:04 ` Pierre-Louis Bossart [this message]
2022-12-13 19:04 ` Pierre-Louis Bossart
2022-12-14 15:42 ` Hans de Goede
2022-12-14 15:42 ` Hans de Goede
2022-12-14 18:16 ` Mark Brown
2022-12-14 18:16 ` Mark Brown
2022-12-14 9:22 ` Hans de Goede
2022-12-14 9:22 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2022-12-14 12:08 Moises Cardona
2022-12-14 15:41 ` Hans de Goede
2022-12-14 15:41 ` Hans de Goede
2022-12-14 21:23 ` Mark Brown
2022-12-14 21:23 ` Mark Brown
[not found] <20221213115950.998113-1-moisesmcardona@gmail.com>
2022-12-13 17:09 ` Pierre-Louis Bossart
2022-12-12 20:58 Moises Cardona
2022-12-13 11:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moisesmcardona@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.