From: Florian Fainelli <f.fainelli@gmail.com>
To: zhouchuangao <zhouchuangao@vivo.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG.
Date: Sat, 24 Apr 2021 18:03:41 -0700 [thread overview]
Message-ID: <08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com> (raw)
In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com>
On 4/24/2021 8:59 AM, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: zhouchuangao <zhouchuangao@vivo.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG.
Date: Sat, 24 Apr 2021 18:03:41 -0700 [thread overview]
Message-ID: <08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com> (raw)
In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com>
On 4/24/2021 8:59 AM, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-25 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 15:59 [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG zhouchuangao
2021-04-24 15:59 ` zhouchuangao
2021-04-25 1:03 ` Florian Fainelli [this message]
2021-04-25 1:03 ` Florian Fainelli
2021-04-26 13:00 ` Thomas Bogendoerfer
2021-04-26 13:00 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhouchuangao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.