From: Waiman Long <llong@redhat.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Waiman Long <llong@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Boqun Feng <boqun.feng@gmail.com>,
Joel Granados <joel.granados@kernel.org>,
Anna Schumaker <anna.schumaker@oracle.com>,
Lance Yang <ioworker0@gmail.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Yongliang Gao <leonylgao@tencent.com>,
Tomasz Figa <tfiga@chromium.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 1/2] hung_task: Show the blocker task if the task is hung on mutex
Date: Wed, 19 Feb 2025 21:21:31 -0500 [thread overview]
Message-ID: <0948872d-06cf-45da-81d0-397197fdbc67@redhat.com> (raw)
In-Reply-To: <20250220110707.a314d394ccf68575047e75cb@kernel.org>
On 2/19/25 9:07 PM, Masami Hiramatsu (Google) wrote:
> On Wed, 19 Feb 2025 18:55:31 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Thu, 20 Feb 2025 07:56:39 +0900
>> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>>
>>>>>> this field, we don't need to take lock, though taking the wait_lock may
>>>>>> still be needed to examine other information inside the mutex.
>>> Do we need to take it just for accessing owner, which is in an atomic?
>> Updating the task_struct would be in the same location as the blocked_on is
>> anyway. I would make it into a wrapper function that is a nop when disabled.
> Should we make it depends on DEBUG_MUTEXES too? I think no. We can introduce
> a different kconfig and wrapper function which calls debug_mutex_*().
No, I don't think so. In fact, the mutex debug code can make use of the
new fields for additional checking. I believe DEBUG_MUTEXES should
select the new option.
Cheers,
Longman
next prev parent reply other threads:[~2025-02-20 2:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 13:00 [PATCH 0/2] hung_task: Dump the blocking task stacktrace Masami Hiramatsu (Google)
2025-02-19 13:00 ` [PATCH 1/2] hung_task: Show the blocker task if the task is hung on mutex Masami Hiramatsu (Google)
2025-02-19 16:23 ` Steven Rostedt
2025-02-19 20:18 ` Waiman Long
2025-02-19 20:24 ` Steven Rostedt
2025-02-19 22:44 ` Waiman Long
2025-02-19 22:56 ` Masami Hiramatsu
2025-02-19 23:55 ` Steven Rostedt
2025-02-20 1:52 ` Lance Yang
2025-02-20 2:07 ` Masami Hiramatsu
2025-02-20 2:21 ` Waiman Long [this message]
2025-02-20 2:23 ` Steven Rostedt
2025-02-20 1:36 ` Waiman Long
2025-02-20 1:41 ` Steven Rostedt
2025-02-20 2:15 ` Waiman Long
2025-02-20 2:27 ` Steven Rostedt
2025-02-20 3:29 ` Waiman Long
2025-02-20 2:59 ` Masami Hiramatsu
2025-02-20 3:37 ` Waiman Long
2025-02-20 9:29 ` Masami Hiramatsu
2025-02-20 13:28 ` Waiman Long
2025-02-20 2:40 ` Masami Hiramatsu
2025-02-20 3:11 ` Steven Rostedt
2025-02-20 13:13 ` Waiman Long
2025-02-20 16:30 ` Steven Rostedt
2025-02-19 23:09 ` Masami Hiramatsu
2025-02-19 23:58 ` Steven Rostedt
2025-02-20 2:08 ` Masami Hiramatsu
2025-02-20 2:25 ` Waiman Long
2025-02-20 1:40 ` Waiman Long
2025-02-20 2:45 ` Sergey Senozhatsky
2025-02-20 4:19 ` Sergey Senozhatsky
2025-02-20 3:46 ` Sergey Senozhatsky
2025-02-20 3:49 ` Waiman Long
2025-02-20 9:25 ` Masami Hiramatsu
2025-02-19 13:00 ` [PATCH 2/2] samples: Add hung_task detector mutex blocking sample Masami Hiramatsu (Google)
2025-02-19 13:33 ` [PATCH 0/2] hung_task: Dump the blocking task stacktrace Lance Yang
2025-02-19 15:02 ` Lance Yang
2025-02-19 20:20 ` Waiman Long
2025-02-20 1:27 ` Lance Yang
2025-02-20 14:18 ` Masami Hiramatsu
2025-02-20 14:22 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0948872d-06cf-45da-81d0-397197fdbc67@redhat.com \
--to=llong@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@oracle.com \
--cc=boqun.feng@gmail.com \
--cc=ioworker0@gmail.com \
--cc=joel.granados@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=leonylgao@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.