From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Sekhar Nori <nsekhar@ti.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
linux-i2c@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH] i2c: davinci: Avoid zero value of CLKH
Date: Fri, 20 Jul 2018 13:43:46 -0500 [thread overview]
Message-ID: <0c29ccf5-4077-47a2-e7e0-c89ffcf8cb0b@ti.com> (raw)
In-Reply-To: <ab965f1d-de6c-75f7-9ebd-35d31ed3de18@ti.com>
On 07/17/2018 06:57 AM, Sekhar Nori wrote:
> On Friday 13 July 2018 08:50 PM, Alexander Sverdlin wrote:
>> If CLKH is set to 0 I2C clock is not generated at all, so avoid this value
>> and stretch the clock in this case.
>
> This must be by observation since specification does not seem to state
> this.
It will be good to know (mention) on what hw was it observed?
>
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> In any case, the patch is fine.
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
>
[...]
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: davinci: Avoid zero value of CLKH
Date: Fri, 20 Jul 2018 13:43:46 -0500 [thread overview]
Message-ID: <0c29ccf5-4077-47a2-e7e0-c89ffcf8cb0b@ti.com> (raw)
In-Reply-To: <ab965f1d-de6c-75f7-9ebd-35d31ed3de18@ti.com>
On 07/17/2018 06:57 AM, Sekhar Nori wrote:
> On Friday 13 July 2018 08:50 PM, Alexander Sverdlin wrote:
>> If CLKH is set to 0 I2C clock is not generated at all, so avoid this value
>> and stretch the clock in this case.
>
> This must be by observation since specification does not seem to state
> this.
It will be good to know (mention) on what hw was it observed?
>
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> In any case, the patch is fine.
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
>
[...]
--
regards,
-grygorii
next prev parent reply other threads:[~2018-07-20 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 15:20 [PATCH] i2c: davinci: Avoid zero value of CLKH Alexander Sverdlin
2018-07-13 15:20 ` Alexander Sverdlin
2018-07-17 11:57 ` Sekhar Nori
2018-07-17 11:57 ` Sekhar Nori
2018-07-20 18:43 ` Grygorii Strashko [this message]
2018-07-20 18:43 ` Grygorii Strashko
2018-07-20 22:18 ` Wolfram Sang
2018-07-20 22:18 ` Wolfram Sang
2018-07-23 18:07 ` Wolfram Sang
2018-07-23 18:07 ` Wolfram Sang
2018-07-24 6:17 ` Sekhar Nori
2018-07-24 6:17 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c29ccf5-4077-47a2-e7e0-c89ffcf8cb0b@ti.com \
--to=grygorii.strashko@ti.com \
--cc=alexander.sverdlin@nokia.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.