From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: unconditionally unlock panel regs
Date: Tue, 14 Dec 2010 20:45:14 +0000 [thread overview]
Message-ID: <0d30dc$kf996t@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20101214121759.11b8aa3a@jbarnes-desktop>
On Tue, 14 Dec 2010 12:17:59 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> In the panel_on function we skip everything if the panel is already
> powered up. However, if it's powered up but not unlocked, subsequent
> register writes may fail.
>
> So unlock the regs regardless of the panel state to allow other mode
> setting programming to occur normally.
That looks to be consistent with other [ab]users of PP_CONTROL. Can you
tidy up the function to remove the duplicate code afterwards?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-12-14 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 20:17 [PATCH] drm/i915: unconditionally unlock panel regs Jesse Barnes
2010-12-14 20:45 ` Chris Wilson [this message]
2010-12-14 21:15 ` Jesse Barnes
2010-12-15 17:27 ` Jim Gettys
2010-12-14 22:15 ` Jan-Hendrik Zab
2010-12-15 13:31 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$kf996t@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.