All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan-Hendrik Zab <jan@jhz.name>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: drm/i915: unconditionally unlock panel regs
Date: Tue, 14 Dec 2010 23:15:28 +0100	[thread overview]
Message-ID: <20101214221528.GA61196@jhz.name> (raw)
In-Reply-To: <20101214121759.11b8aa3a@jbarnes-desktop>

On 14/12/10 12:17 -0800, Jesse Barnes wrote:
> In the panel_on function we skip everything if the panel is already
> powered up.  However, if it's powered up but not unlocked, subsequent
> register writes may fail.
> 
> So unlock the regs regardless of the panel state to allow other mode
> setting programming to occur normally.
> 
> [Still waiting to hear from bug reporters & testers on this one, but
> it does get my Vaio working again, with or without the eDP VBT patch
> reverted.]

My Vaio VPCZ1 works with your patch in addition to the eDP VBT patch
(or rather the revert reverted). It does not work without the eDP VBT
patch.

The above is true for drm-intel-next and drm-intel-fixes.

	-jhz

-- 
http://jhz.name/blog

  parent reply	other threads:[~2010-12-14 22:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-14 20:17 [PATCH] drm/i915: unconditionally unlock panel regs Jesse Barnes
2010-12-14 20:45 ` Chris Wilson
2010-12-14 21:15   ` Jesse Barnes
2010-12-15 17:27     ` Jim Gettys
2010-12-14 22:15 ` Jan-Hendrik Zab [this message]
2010-12-15 13:31   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101214221528.GA61196@jhz.name \
    --to=jan@jhz.name \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.