From: Chris Wilson <chris@chris-wilson.co.uk>
To: Carl Worth <cworth@cworth.org>,
"U. Artie Eoff" <ullysses.a.eoff@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] configure: updated m4 macro check in configure.ac
Date: Tue, 21 Dec 2010 22:33:35 +0000 [thread overview]
Message-ID: <0d30dc$khhefu@orsmga001.jf.intel.com> (raw)
In-Reply-To: <87fwtqdavt.fsf@yoom.home.cworth.org>
On Tue, 21 Dec 2010 14:22:30 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Tue, 21 Dec 2010 15:10:41 -0700, "U. Artie Eoff" <ullysses.a.eoff@intel.com> wrote:
> > Added m4 check for XORG_DRIVER_CHECK_EXT macro definition. Updated m4
> > fatal messages to give better hint on how to resolve error when xorg
> > macros are missing. Previously, configure would continue in spite of
> > the missing macros and the build would fail for syntax errors.
>
> Thanks so much, Artie!
>
> I've now pushed this change out.
>
> Only just after pushing it did I notice that the commit message is all
> one long line. No big deal for this commit, but in future commits, if
> you wrap that paragraph to fit within 80 columns then some tools will
> display the commit message more cleanly.
And the duplicated string without mentioning the upstream source...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-12-21 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 22:10 [PATCH] configure: updated m4 macro check in configure.ac U. Artie Eoff
2010-12-21 22:22 ` Carl Worth
2010-12-21 22:33 ` Chris Wilson [this message]
2010-12-21 22:49 ` Paul Menzel
2010-12-21 23:54 ` Julien Cristau
2010-12-22 0:03 ` Eoff, Ullysses A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$khhefu@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=cworth@cworth.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ullysses.a.eoff@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.