[PATCH] configure: updated m4 macro check in configure.ac

[PATCH] configure: updated m4 macro check in configure.ac

[U. Artie Eoff]

Added m4 check for XORG_DRIVER_CHECK_EXT macro definition.  Updated m4 fatal messages to give better hint on how to resolve error when xorg macros are missing.  Previously, configure would continue in spite of the missing macros and the build would fail for syntax errors. 
---
 configure.ac |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 05848ea..e6517e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,10 +36,16 @@ AM_MAINTAINER_MODE
 
 # Require X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS
 m4_ifndef([XORG_MACROS_VERSION],
-          [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])])
+          [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen.
+  Try "apt-get install xutils-dev" or "yum install xorg-x11-util-macros"])])
 XORG_MACROS_VERSION(1.8)
 XORG_DEFAULT_OPTIONS
 
+# Require X.Org server macros (i.e. XORG_DRIVER_CHECK_EXT) to check for required modules 
+m4_ifndef([XORG_DRIVER_CHECK_EXT],
+          [m4_fatal([must install xorg-server macros before running autoconf/autogen.
+  Try "apt-get install xserver-xorg-dev" or "yum install xorg-x11-server-devel"])])
+
 # Initialize libtool
 AC_DISABLE_STATIC
 AC_PROG_LIBTOOL
-- 
1.7.3.3

Re: [PATCH] configure: updated m4 macro check in configure.ac

[Carl Worth]

[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]

On Tue, 21 Dec 2010 15:10:41 -0700, "U. Artie Eoff" <ullysses.a.eoff@intel.com> wrote:
> Added m4 check for XORG_DRIVER_CHECK_EXT macro definition.  Updated m4
> fatal messages to give better hint on how to resolve error when xorg
> macros are missing.  Previously, configure would continue in spite of
> the missing macros and the build would fail for syntax errors.

Thanks so much, Artie!

I've now pushed this change out.

Only just after pushing it did I notice that the commit message is all
one long line. No big deal for this commit, but in future commits, if
you wrap that paragraph to fit within 80 columns then some tools will
display the commit message more cleanly.

Thanks again,

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] configure: updated m4 macro check in configure.ac

[Chris Wilson]

On Tue, 21 Dec 2010 14:22:30 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Tue, 21 Dec 2010 15:10:41 -0700, "U. Artie Eoff" <ullysses.a.eoff@intel.com> wrote:
> > Added m4 check for XORG_DRIVER_CHECK_EXT macro definition.  Updated m4
> > fatal messages to give better hint on how to resolve error when xorg
> > macros are missing.  Previously, configure would continue in spite of
> > the missing macros and the build would fail for syntax errors.
> 
> Thanks so much, Artie!
> 
> I've now pushed this change out.
> 
> Only just after pushing it did I notice that the commit message is all
> one long line. No big deal for this commit, but in future commits, if
> you wrap that paragraph to fit within 80 columns then some tools will
> display the commit message more cleanly.

And the duplicated string without mentioning the upstream source...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] configure: updated m4 macro check in configure.ac

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 1642 bytes --]

Dear Artie,


Am Dienstag, den 21.12.2010, 15:10 -0700 schrieb U. Artie Eoff:
> Added m4 check for XORG_DRIVER_CHECK_EXT macro definition.  Updated m4
> fatal messages to give better hint on how to resolve error when xorg
> macros are missing.  Previously, configure would continue in spite of
> the missing macros and the build would fail for syntax errors. 
> ---
>  configure.ac |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 05848ea..e6517e6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,10 +36,16 @@ AM_MAINTAINER_MODE
>  
>  # Require X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS
>  m4_ifndef([XORG_MACROS_VERSION],
> -          [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])])
> +          [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen.
> +  Try "apt-get install xutils-dev" or "yum install xorg-x11-util-macros"])])

`aptitude` is the recommended package manager for Debian [1].

>  XORG_MACROS_VERSION(1.8)
>  XORG_DEFAULT_OPTIONS
>  
> +# Require X.Org server macros (i.e. XORG_DRIVER_CHECK_EXT) to check for required modules 
> +m4_ifndef([XORG_DRIVER_CHECK_EXT],
> +          [m4_fatal([must install xorg-server macros before running autoconf/autogen.
> +  Try "apt-get install xserver-xorg-dev" or "yum install xorg-x11-server-devel"])])
> +
>  # Initialize libtool
>  AC_DISABLE_STATIC
>  AC_PROG_LIBTOOL


Thanks,

Paul


[1] http://www.debian.org/doc/manuals/debian-faq/ch-uptodate.en.html (9.1.1)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] configure: updated m4 macro check in configure.ac

[Julien Cristau]

On Tue, Dec 21, 2010 at 23:49:31 +0100, Paul Menzel wrote:

> `aptitude` is the recommended package manager for Debian [1].

I don't believe that's true.  But it's kind of irrelevant anyway, it
should be enough to give the name of the package to install.

Cheers,
Julien

Re: [PATCH] configure: updated m4 macro check in configure.ac

[Eoff, Ullysses A]

> -----Original Message-----
> From: intel-gfx-bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org
> [mailto:intel-gfx-
> bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org] On Behalf Of
> Julien Cristau
> Sent: Tuesday, December 21, 2010 3:54 PM
> To: Paul Menzel
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] configure: updated m4 macro check in
> configure.ac
> 
> On Tue, Dec 21, 2010 at 23:49:31 +0100, Paul Menzel wrote:
> 
> > `aptitude` is the recommended package manager for Debian [1].
> 
> I don't believe that's true.  But it's kind of irrelevant anyway, it
> should be enough to give the name of the package to install.
> 
> Cheers,
> Julien
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

I agree, it is irrelevant... I'll remove the package manager references and mention the upstream source, too.

Thanks,
U. Artie Eoff