From: Choi Chanwoo <cwchoi00@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 3/7] dt-bindings: devfreq: event: rockchip,dfi: add rk3576
Date: Sun, 15 Nov 2026 09:58:48 +0900 [thread overview]
Message-ID: <0f536451-9f7b-46f7-acca-e10e54dec37e@gmail.com> (raw)
In-Reply-To: <20260921-b4-rockchip-dfi-rk3576-support-v2-3-04f847016321@collabora.com>
On 9/22/2026 6:15 AM, Sebastian Reichel wrote:
> From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>
> The RK3576 has DFI hardware for monitoring the DDR's bandwidth much
> like other rockchip SoCs do. Unlike the RK3588 however, it only has two
> memory channels, so only two per-channel pclks for DFI.
>
> Add a compatible for this SoC's variant, and add it to the conditionals
> at the bottom of the bindings file.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../bindings/devfreq/event/rockchip,dfi.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index 3450e28b4020..dcf3bbde3e8d 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - rockchip,rk3399-dfi
> - rockchip,rk3568-dfi
> + - rockchip,rk3576-dfi
> - rockchip,rk3588-dfi
>
> clocks:
> @@ -64,6 +65,24 @@ allOf:
> - clocks
> - clock-names
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3576-dfi
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + minItems: 2
> + maxItems: 2
> + required:
> + - clocks
> + - clock-names
> +
> - if:
> properties:
> compatible:
>
When I applied it, there are some error.
Could you please resend it on latest commit?
--
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Choi Chanwoo <cwchoi00@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 3/7] dt-bindings: devfreq: event: rockchip,dfi: add rk3576
Date: Sun, 15 Nov 2026 09:58:48 +0900 [thread overview]
Message-ID: <0f536451-9f7b-46f7-acca-e10e54dec37e@gmail.com> (raw)
In-Reply-To: <20260921-b4-rockchip-dfi-rk3576-support-v2-3-04f847016321@collabora.com>
On 9/22/2026 6:15 AM, Sebastian Reichel wrote:
> From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>
> The RK3576 has DFI hardware for monitoring the DDR's bandwidth much
> like other rockchip SoCs do. Unlike the RK3588 however, it only has two
> memory channels, so only two per-channel pclks for DFI.
>
> Add a compatible for this SoC's variant, and add it to the conditionals
> at the bottom of the bindings file.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../bindings/devfreq/event/rockchip,dfi.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index 3450e28b4020..dcf3bbde3e8d 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - rockchip,rk3399-dfi
> - rockchip,rk3568-dfi
> + - rockchip,rk3576-dfi
> - rockchip,rk3588-dfi
>
> clocks:
> @@ -64,6 +65,24 @@ allOf:
> - clocks
> - clock-names
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3576-dfi
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + minItems: 2
> + maxItems: 2
> + required:
> + - clocks
> + - clock-names
> +
> - if:
> properties:
> compatible:
>
When I applied it, there are some error.
Could you please resend it on latest commit?
--
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-15 0:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 21:15 [PATCH v2 0/7] PM / devfreq: rockchip-dfi: RK3576 support Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-09-21 21:15 ` [PATCH v2 1/7] dt-bindings: clock: rk3576: add more DFI clocks Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-10-05 17:10 ` Rob Herring (Arm)
2026-10-05 17:10 ` Rob Herring (Arm)
2026-09-21 21:15 ` [PATCH v2 2/7] clk: rockchip: rk3576: add missing DFI clock branch Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-09-21 21:15 ` [PATCH v2 3/7] dt-bindings: devfreq: event: rockchip,dfi: add rk3576 Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-10-05 17:11 ` Rob Herring (Arm)
2026-10-05 17:11 ` Rob Herring (Arm)
2026-11-15 0:58 ` Choi Chanwoo [this message]
2026-11-15 0:58 ` Choi Chanwoo
2026-11-15 1:32 ` Sebastian Reichel
2026-11-15 1:32 ` Sebastian Reichel
2026-09-21 21:15 ` [PATCH v2 4/7] arm64: dts: rockchip: add DFI node to RK3576 Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-09-21 21:15 ` [PATCH v2 5/7] PM / devfreq: rockchip-dfi: move register offsets to variant struct Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-11-15 0:59 ` Choi Chanwoo
2026-11-15 0:59 ` Choi Chanwoo
2026-09-21 21:15 ` [PATCH v2 6/7] PM / devfreq: rockchip-dfi: prepare support for v4 DDRMON Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-11-15 0:59 ` Choi Chanwoo
2026-11-15 0:59 ` Choi Chanwoo
2026-09-21 21:15 ` [PATCH v2 7/7] PM / devfreq: rockchip-dfi: add RK3576 support Sebastian Reichel
2026-09-21 21:15 ` Sebastian Reichel
2026-11-15 1:00 ` Choi Chanwoo
2026-11-15 1:00 ` Choi Chanwoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f536451-9f7b-46f7-acca-e10e54dec37e@gmail.com \
--to=cwchoi00@gmail.com \
--cc=bmasney+clk@redhat.com \
--cc=chanwoo@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbrunet+clk@baylibre.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=myungjoo.ham@samsung.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.