Re: [PATCH v2 3/7] dt-bindings: devfreq: event: rockchip,dfi: add rk3576

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: chanwoo@kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	 Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	 MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	 linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	 kernel@collabora.com
Subject: Re: [PATCH v2 3/7] dt-bindings: devfreq: event: rockchip,dfi: add rk3576
Date: Sun, 15 Nov 2026 02:32:59 +0100	[thread overview]
Message-ID: <avkHvso6ljhn693V@venus> (raw)
In-Reply-To: <0f536451-9f7b-46f7-acca-e10e54dec37e@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]

Hi,

On Sun, Nov 15, 2026 at 09:58:48AM +0900, Choi Chanwoo wrote:
> On 9/22/2026 6:15 AM, Sebastian Reichel wrote:
> > From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> > 
> > The RK3576 has DFI hardware for monitoring the DDR's bandwidth much
> > like other rockchip SoCs do. Unlike the RK3588 however, it only has two
> > memory channels, so only two per-channel pclks for DFI.
> > 
> > Add a compatible for this SoC's variant, and add it to the conditionals
> > at the bottom of the bindings file.
> > 
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  .../bindings/devfreq/event/rockchip,dfi.yaml          | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> > index 3450e28b4020..dcf3bbde3e8d 100644
> > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> > @@ -14,6 +14,7 @@ properties:
> >      enum:
> >        - rockchip,rk3399-dfi
> >        - rockchip,rk3568-dfi
> > +      - rockchip,rk3576-dfi
> >        - rockchip,rk3588-dfi
> >  
> >    clocks:
> > @@ -64,6 +65,24 @@ allOf:
> >          - clocks
> >          - clock-names
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - rockchip,rk3576-dfi
> > +    then:
> > +      properties:
> > +        clocks:
> > +          minItems: 2
> > +          maxItems: 2
> > +        clock-names:
> > +          minItems: 2
> > +          maxItems: 2
> > +      required:
> > +        - clocks
> > +        - clock-names
> > +
> >    - if:
> >        properties:
> >          compatible:
> > 
> 
> When I applied it, there are some error.
> Could you please resend it on latest commit?

This patch should still apply cleanly, when you merge this one first:

https://lore.kernel.org/linux-rockchip/20260921-rockchip-dfi-cleanup-v2-2-43ff34ac8599@collabora.com/

Generally all DFI patches from the linked "PM / devfreq:
rockchip-dfi: cleanups" series are backwarts and forward compatible.
You can just pick them up (i.e. patches 2, 3, 4, 5, and 7).

Afterwards from this series you can pick up 3, 5, 6, 7.

I can then ask Heiko to pick the clock and DT changes.

I probably should have structured this submission a bit differently,
sorry for the mess.

Thanks for your reviews.

Greetings,

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip