From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, grandmastertriplej@gmail.com,
Mario Limonciello <mario.limonciello@amd.com>,
"Natikar, Basavaraj" <basavaraj.natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH 2/2] ata: libata: Correct libata.force parameter documentation
Date: Sun, 20 Sep 2026 13:35:40 +0900 [thread overview]
Message-ID: <1022afd9-3443-4f1d-a35a-e550615a67d6@kernel.org> (raw)
In-Reply-To: <aq0zTqvUzopOdQwF@ryzen>
On 9/18/26 21:49, Niklas Cassel wrote:
> On Fri, Sep 18, 2026 at 02:40:33PM +0200, Niklas Cassel wrote:
>> Align the documented libata.force options with their implementation.
>> The force table accepts PIO modes 0 through 6, not mode 7, and ncqati
>> controls NCQ generally rather than only queued TRIM.
>>
>> The max_sec_1024 and max_sec_lba48 options only set transfer size
>> limits. Remove the misleading claim that they can also clear them.
>>
>> Signed-off-by: Niklas Cassel <cassel@kernel.org>
>> ---
>> Documentation/admin-guide/kernel-parameters.txt | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index 33cd30996e47..24459f7ff810 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -3491,7 +3491,7 @@ Kernel parameters
>>
>> * SATA link speed limit: 1.5Gbps or 3.0Gbps.
>>
>> - * Transfer mode: pio[0-7], mwdma[0-4] and udma[0-7].
>> + * Transfer mode: pio[0-6], mwdma[0-4] and udma[0-7].
>> udma[/][16,25,33,44,66,100,133] notation is also
>> allowed.
>>
>> @@ -3509,7 +3509,7 @@ Kernel parameters
>>
>> * [no]ncqtrim: Enable or disable queued DSM TRIM.
>>
>> - * [no]ncqati: Enable or disable NCQ trim on ATI chipset.
>> + * [no]ncqati: Enable or disable NCQ on ATI chipsets.
>
> Hmm.. I guess we could theoretically remove the [no]ncqati parameter from
> libata.force.
> If a user wants to enable/disable ncq, they can use the [no]ncq libata.force
> parameter.
>
> However, since this libata.force kernel parameter already exists, I guess it
> might actually be used by someone, so we can't really remove it without
> potentially breaking existing setups, so I guess the easiest thing is just
> to keep it, even if it is not strictly needed.
It can be needed on a machine that has multiple adapters from different vendors.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-09-20 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 12:40 [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation Niklas Cassel
2026-09-18 12:40 ` [PATCH 1/2] ata: libata-core: Extend Samsung LPM quirk to AMD controllers Niklas Cassel
2026-09-19 17:21 ` Mario Limonciello
2026-09-20 4:33 ` Damien Le Moal
2026-09-18 12:40 ` [PATCH 2/2] ata: libata: Correct libata.force parameter documentation Niklas Cassel
2026-09-18 12:49 ` Niklas Cassel
2026-09-20 4:35 ` Damien Le Moal [this message]
2026-09-21 11:26 ` Niklas Cassel
2026-09-20 4:34 ` Damien Le Moal
2026-09-21 11:21 ` [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1022afd9-3443-4f1d-a35a-e550615a67d6@kernel.org \
--to=dlemoal@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=basavaraj.natikar@amd.com \
--cc=cassel@kernel.org \
--cc=grandmastertriplej@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.