From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, grandmastertriplej@gmail.com,
Mario Limonciello <mario.limonciello@amd.com>,
"Natikar, Basavaraj" <basavaraj.natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH 1/2] ata: libata-core: Extend Samsung LPM quirk to AMD controllers
Date: Sun, 20 Sep 2026 13:33:54 +0900 [thread overview]
Message-ID: <e28ecd67-abd3-444e-b218-136ec2d9735b@kernel.org> (raw)
In-Reply-To: <20260918124030.1962773-5-cassel@kernel.org>
On 9/18/26 21:40, Niklas Cassel wrote:
> A Samsung SSD 870 QVO 8TB connected to an AMD 600 Series chipset SATA
> controller is reported to time out on STANDBY IMMEDIATE during system
> suspend with med_power_with_dipm enabled. The command completes when
> using max_performance instead.
>
> The existing Samsung LPM quirk only matches ATI controllers, leaving
> AMD controllers unaffected. Rename it to
> ATA_QUIRK_NO_LPM_ON_ATI_AND_AMD and extend the vendor check to AMD for
> the same Samsung SSD model patterns. Keep LPM behavior unchanged for
> other controller vendors, including Intel.
>
> Leave ATA_QUIRK_NO_NCQ_ON_ATI restricted to ATI, since the reported AMD
> issue concerns LPM rather than NCQ.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221986
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Looks OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-09-20 4:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 12:40 [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation Niklas Cassel
2026-09-18 12:40 ` [PATCH 1/2] ata: libata-core: Extend Samsung LPM quirk to AMD controllers Niklas Cassel
2026-09-19 17:21 ` Mario Limonciello
2026-09-20 4:33 ` Damien Le Moal [this message]
2026-09-18 12:40 ` [PATCH 2/2] ata: libata: Correct libata.force parameter documentation Niklas Cassel
2026-09-18 12:49 ` Niklas Cassel
2026-09-20 4:35 ` Damien Le Moal
2026-09-21 11:26 ` Niklas Cassel
2026-09-20 4:34 ` Damien Le Moal
2026-09-21 11:21 ` [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e28ecd67-abd3-444e-b218-136ec2d9735b@kernel.org \
--to=dlemoal@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=basavaraj.natikar@amd.com \
--cc=cassel@kernel.org \
--cc=grandmastertriplej@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.