All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, grandmastertriplej@gmail.com,
	Mario Limonciello <mario.limonciello@amd.com>,
	"Natikar, Basavaraj" <basavaraj.natikar@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Niklas Cassel <cassel@kernel.org>
Subject: [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation
Date: Fri, 18 Sep 2026 14:40:31 +0200	[thread overview]
Message-ID: <20260918124030.1962773-4-cassel@kernel.org> (raw)

Hello,

A user reports that a Samsung SSD 870 QVO 8TB connected to an AMD 600
Series chipset SATA controller times out on STANDBY IMMEDIATE during
system suspend with med_power_with_dipm enabled. The command completes
with max_performance instead.

Patch 1 extends the existing Samsung LPM quirk from ATI to AMD
controllers, renaming it to ATA_QUIRK_NO_LPM_ON_ATI_AND_AMD. It keeps the
same drive model matches and leaves the NCQ quirk restricted to ATI.
LPM behavior on other controller vendors, including Intel, is unchanged.
The underlying controller/device interaction has not been root-caused.

Patch 2 separately corrects the libata.force parameter documentation:
the supported PIO range, the scope of ncqati, and the set-only behavior
of max_sec_1024 and max_sec_lba48. It introduces no new force options.

Note that the ATI (and now AMD) LPM quirk never had a libata.force option,
and neither do we want to add one.
If a user wants to force enable/disable lpm, they can use the existing
[no]lpm libata.force parameter. We therefore do not have and documentation
in kernel-parameters.txt to change.

Bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=221986

Kind regards,
Niklas

Niklas Cassel (2):
  ata: libata-core: Extend Samsung LPM quirk to AMD controllers
  ata: libata: Correct libata.force parameter documentation

 Documentation/admin-guide/kernel-parameters.txt | 10 ++++------
 drivers/ata/libata-core.c                       | 15 ++++++++-------
 include/linux/libata.h                          |  4 ++--
 3 files changed, 14 insertions(+), 15 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-09-18 12:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 12:40 Niklas Cassel [this message]
2026-09-18 12:40 ` [PATCH 1/2] ata: libata-core: Extend Samsung LPM quirk to AMD controllers Niklas Cassel
2026-09-19 17:21   ` Mario Limonciello
2026-09-20  4:33   ` Damien Le Moal
2026-09-18 12:40 ` [PATCH 2/2] ata: libata: Correct libata.force parameter documentation Niklas Cassel
2026-09-18 12:49   ` Niklas Cassel
2026-09-20  4:35     ` Damien Le Moal
2026-09-21 11:26       ` Niklas Cassel
2026-09-20  4:34   ` Damien Le Moal
2026-09-21 11:21 ` [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918124030.1962773-4-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=basavaraj.natikar@amd.com \
    --cc=dlemoal@kernel.org \
    --cc=grandmastertriplej@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.