From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] i2c driver changes for 2.5.64
Date: Thu, 19 May 2005 06:23:49 +0000 [thread overview]
Message-ID: <10476033233796@kroah.com> (raw)
In-Reply-To: <1047603322689@kroah.com>
In-Reply-To: <10476033213315@kroah.com>
ChangeSet 1.1111, 2003/03/13 12:16:52-08:00, greg@kroah.com
i2c: i2c-piix4.c: Clean up the ibm dma scan logic
Also export the is_unsafe_smbus variable, which is needed.
arch/i386/kernel/dmi_scan.c | 3 +++
drivers/i2c/busses/i2c-piix4.c | 20 ++------------------
2 files changed, 5 insertions(+), 18 deletions(-)
diff -Nru a/arch/i386/kernel/dmi_scan.c b/arch/i386/kernel/dmi_scan.c
--- a/arch/i386/kernel/dmi_scan.c Thu Mar 13 16:57:17 2003
+++ b/arch/i386/kernel/dmi_scan.c Thu Mar 13 16:57:17 2003
@@ -3,6 +3,7 @@
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/apm_bios.h>
#include <linux/slab.h>
#include <asm/io.h>
@@ -893,3 +894,5 @@
if(err = 0)
dmi_check_blacklist();
}
+
+EXPORT_SYMBOL(is_unsafe_smbus);
diff -Nru a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
--- a/drivers/i2c/busses/i2c-piix4.c Thu Mar 13 16:57:17 2003
+++ b/drivers/i2c/busses/i2c-piix4.c Thu Mar 13 16:57:17 2003
@@ -28,7 +28,6 @@
Note: we assume there can only be one device, with one SMBus interface.
*/
-#include <linux/version.h>
#include <linux/module.h>
#include <linux/config.h>
#include <linux/pci.h>
@@ -104,31 +103,18 @@
static unsigned short piix4_smba = 0;
-#ifdef CONFIG_X86
/*
* Get DMI information.
*/
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,34)
-void dmi_scan_mach(void);
-#endif
-
-static int __init ibm_dmi_probe(void)
+static int ibm_dmi_probe(void)
{
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,34)
+#ifdef CONFIG_X86
extern int is_unsafe_smbus;
return is_unsafe_smbus;
#else
-#define IBM_SIGNATURE "IBM"
- dmi_scan_mach();
- if(dmi_ident[DMI_SYS_VENDOR] = NULL)
- return 0;
- if(strncmp(dmi_ident[DMI_SYS_VENDOR], IBM_SIGNATURE,
- strlen(IBM_SIGNATURE)) = 0)
- return 1;
return 0;
#endif
}
-#endif
static int piix4_setup(struct pci_dev *PIIX4_dev, const struct pci_device_id *id)
{
@@ -141,7 +127,6 @@
printk(KERN_INFO "i2c-piix4.o: Found %s device\n", PIIX4_dev->dev.name);
-#ifdef CONFIG_X86
if(ibm_dmi_probe()) {
printk
(KERN_ERR "i2c-piix4.o: IBM Laptop detected; this module may corrupt\n");
@@ -150,7 +135,6 @@
error_return = -EPERM;
goto END;
}
-#endif
/* Determine the address of the SMBus areas */
if (force_addr) {
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver changes for 2.5.64
Date: Thu, 13 Mar 2003 16:55 -0800 [thread overview]
Message-ID: <10476033233796@kroah.com> (raw)
In-Reply-To: <1047603322689@kroah.com>
ChangeSet 1.1111, 2003/03/13 12:16:52-08:00, greg@kroah.com
i2c: i2c-piix4.c: Clean up the ibm dma scan logic
Also export the is_unsafe_smbus variable, which is needed.
arch/i386/kernel/dmi_scan.c | 3 +++
drivers/i2c/busses/i2c-piix4.c | 20 ++------------------
2 files changed, 5 insertions(+), 18 deletions(-)
diff -Nru a/arch/i386/kernel/dmi_scan.c b/arch/i386/kernel/dmi_scan.c
--- a/arch/i386/kernel/dmi_scan.c Thu Mar 13 16:57:17 2003
+++ b/arch/i386/kernel/dmi_scan.c Thu Mar 13 16:57:17 2003
@@ -3,6 +3,7 @@
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/apm_bios.h>
#include <linux/slab.h>
#include <asm/io.h>
@@ -893,3 +894,5 @@
if(err == 0)
dmi_check_blacklist();
}
+
+EXPORT_SYMBOL(is_unsafe_smbus);
diff -Nru a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
--- a/drivers/i2c/busses/i2c-piix4.c Thu Mar 13 16:57:17 2003
+++ b/drivers/i2c/busses/i2c-piix4.c Thu Mar 13 16:57:17 2003
@@ -28,7 +28,6 @@
Note: we assume there can only be one device, with one SMBus interface.
*/
-#include <linux/version.h>
#include <linux/module.h>
#include <linux/config.h>
#include <linux/pci.h>
@@ -104,31 +103,18 @@
static unsigned short piix4_smba = 0;
-#ifdef CONFIG_X86
/*
* Get DMI information.
*/
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,34)
-void dmi_scan_mach(void);
-#endif
-
-static int __init ibm_dmi_probe(void)
+static int ibm_dmi_probe(void)
{
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,34)
+#ifdef CONFIG_X86
extern int is_unsafe_smbus;
return is_unsafe_smbus;
#else
-#define IBM_SIGNATURE "IBM"
- dmi_scan_mach();
- if(dmi_ident[DMI_SYS_VENDOR] == NULL)
- return 0;
- if(strncmp(dmi_ident[DMI_SYS_VENDOR], IBM_SIGNATURE,
- strlen(IBM_SIGNATURE)) == 0)
- return 1;
return 0;
#endif
}
-#endif
static int piix4_setup(struct pci_dev *PIIX4_dev, const struct pci_device_id *id)
{
@@ -141,7 +127,6 @@
printk(KERN_INFO "i2c-piix4.o: Found %s device\n", PIIX4_dev->dev.name);
-#ifdef CONFIG_X86
if(ibm_dmi_probe()) {
printk
(KERN_ERR "i2c-piix4.o: IBM Laptop detected; this module may corrupt\n");
@@ -150,7 +135,6 @@
error_return = -EPERM;
goto END;
}
-#endif
/* Determine the address of the SMBus areas */
if (force_addr) {
next prev parent reply other threads:[~2005-05-19 6:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-14 0:50 [BK PATCH] i2c driver changes for 2.5.64 Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` [PATCH] " Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH [this message]
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 0:55 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-15 9:49 ` Vojtech Pavlik
2005-05-19 6:23 ` Vojtech Pavlik
2003-03-15 21:46 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-15 22:06 ` Vojtech Pavlik
2005-05-19 6:23 ` Vojtech Pavlik
2005-05-19 6:23 ` Greg KH
2005-05-19 6:23 ` Mark D. Studebaker
2005-05-19 6:23 ` Christoph Hellwig
2005-05-19 6:23 ` Mark D. Studebaker
2005-05-19 6:23 ` Mark D. Studebaker
2005-05-19 6:23 ` Greg KH
2005-05-19 6:23 ` Mark Studebaker
2005-05-19 6:23 ` Greg KH
2005-05-19 6:23 ` Jean Delvare
2003-03-14 8:28 ` Christoph Hellwig
2005-05-19 6:23 ` Christoph Hellwig
2003-03-14 8:21 ` Christoph Hellwig
2005-05-19 6:23 ` Christoph Hellwig
2003-03-14 8:53 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-14 8:19 ` Christoph Hellwig
2005-05-19 6:23 ` Christoph Hellwig
2003-03-14 8:56 ` Greg KH
2005-05-19 6:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10476033233796@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.