From: rusty@linux.co.intel.com (Rusty Lynch)
To: LM Sensors <sensors@stimpy.netroedge.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver
Date: Thu, 19 May 2005 06:24:12 +0000 [thread overview]
Message-ID: <1060731495.11264.8.camel@vmhack> (raw)
While initializing the adm1021 device, the driver is performing a conversion
from fixed point to Celcius on values that were declaired as Celcius. On
my Dell Precision 220 this results in a shutdown after a couple of minutes
running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the
conversion.
--rustyl
diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
--- linux-2.6.0-test3/drivers/i2c/chips/adm1021.c 2003-08-08 21:31:16.000000000 -0700
+++ linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c 2003-08-12 16:54:25.000000000 -0700
@@ -356,13 +356,13 @@
{
/* Initialize the adm1021 chip */
adm1021_write_value(client, ADM1021_REG_TOS_W,
- TEMP_TO_REG(adm1021_INIT_TOS));
+ adm1021_INIT_TOS);
adm1021_write_value(client, ADM1021_REG_THYST_W,
- TEMP_TO_REG(adm1021_INIT_THYST));
+ adm1021_INIT_THYST);
adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+ adm1021_INIT_REMOTE_TOS);
adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+ adm1021_INIT_REMOTE_THYST);
/* Enable ADC and disable suspend mode */
adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
/* Set Conversion rate to 1/sec (this can be tinkered with) */
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Lynch <rusty@linux.co.intel.com>
To: LM Sensors <sensors@stimpy.netroedge.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver
Date: 12 Aug 2003 16:38:13 -0700 [thread overview]
Message-ID: <1060731495.11264.8.camel@vmhack> (raw)
While initializing the adm1021 device, the driver is performing a conversion
from fixed point to Celcius on values that were declaired as Celcius. On
my Dell Precision 220 this results in a shutdown after a couple of minutes
running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the
conversion.
--rustyl
diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
--- linux-2.6.0-test3/drivers/i2c/chips/adm1021.c 2003-08-08 21:31:16.000000000 -0700
+++ linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c 2003-08-12 16:54:25.000000000 -0700
@@ -356,13 +356,13 @@
{
/* Initialize the adm1021 chip */
adm1021_write_value(client, ADM1021_REG_TOS_W,
- TEMP_TO_REG(adm1021_INIT_TOS));
+ adm1021_INIT_TOS);
adm1021_write_value(client, ADM1021_REG_THYST_W,
- TEMP_TO_REG(adm1021_INIT_THYST));
+ adm1021_INIT_THYST);
adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+ adm1021_INIT_REMOTE_TOS);
adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+ adm1021_INIT_REMOTE_THYST);
/* Enable ADC and disable suspend mode */
adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
/* Set Conversion rate to 1/sec (this can be tinkered with) */
next reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 23:38 Rusty Lynch [this message]
2005-05-19 6:24 ` [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver Rusty Lynch
2003-08-14 21:32 ` Greg KH
2005-05-19 6:24 ` [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 Greg KH
2005-05-19 6:24 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060731495.11264.8.camel@vmhack \
--to=rusty@linux.co.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.