* [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver
@ 2005-05-19 6:24 ` Rusty Lynch
0 siblings, 0 replies; 5+ messages in thread
From: Rusty Lynch @ 2003-08-12 23:38 UTC (permalink / raw)
To: LM Sensors; +Cc: lkml
While initializing the adm1021 device, the driver is performing a conversion
from fixed point to Celcius on values that were declaired as Celcius. On
my Dell Precision 220 this results in a shutdown after a couple of minutes
running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the
conversion.
--rustyl
diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
--- linux-2.6.0-test3/drivers/i2c/chips/adm1021.c 2003-08-08 21:31:16.000000000 -0700
+++ linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c 2003-08-12 16:54:25.000000000 -0700
@@ -356,13 +356,13 @@
{
/* Initialize the adm1021 chip */
adm1021_write_value(client, ADM1021_REG_TOS_W,
- TEMP_TO_REG(adm1021_INIT_TOS));
+ adm1021_INIT_TOS);
adm1021_write_value(client, ADM1021_REG_THYST_W,
- TEMP_TO_REG(adm1021_INIT_THYST));
+ adm1021_INIT_THYST);
adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+ adm1021_INIT_REMOTE_TOS);
adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+ adm1021_INIT_REMOTE_THYST);
/* Enable ADC and disable suspend mode */
adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
/* Set Conversion rate to 1/sec (this can be tinkered with) */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver
2005-05-19 6:24 ` Rusty Lynch
@ 2005-05-19 6:24 ` Greg KH
-1 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2003-08-14 21:32 UTC (permalink / raw)
To: Rusty Lynch; +Cc: LM Sensors, lkml
On Tue, Aug 12, 2003 at 04:38:13PM -0700, Rusty Lynch wrote:
> While initializing the adm1021 device, the driver is performing a conversion
> from fixed point to Celcius on values that were declaired as Celcius. On
> my Dell Precision 220 this results in a shutdown after a couple of minutes
> running.
>
> This is a very simple patch against the 2.6.0-test3 tree that just removes the
> conversion.
Applied, thanks.
Next time you might want to CC: me to make sure I catch this.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver
@ 2005-05-19 6:24 ` Rusty Lynch
0 siblings, 0 replies; 5+ messages in thread
From: Rusty Lynch @ 2005-05-19 6:24 UTC (permalink / raw)
To: LM Sensors; +Cc: lkml
While initializing the adm1021 device, the driver is performing a conversion
from fixed point to Celcius on values that were declaired as Celcius. On
my Dell Precision 220 this results in a shutdown after a couple of minutes
running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the
conversion.
--rustyl
diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
--- linux-2.6.0-test3/drivers/i2c/chips/adm1021.c 2003-08-08 21:31:16.000000000 -0700
+++ linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c 2003-08-12 16:54:25.000000000 -0700
@@ -356,13 +356,13 @@
{
/* Initialize the adm1021 chip */
adm1021_write_value(client, ADM1021_REG_TOS_W,
- TEMP_TO_REG(adm1021_INIT_TOS));
+ adm1021_INIT_TOS);
adm1021_write_value(client, ADM1021_REG_THYST_W,
- TEMP_TO_REG(adm1021_INIT_THYST));
+ adm1021_INIT_THYST);
adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+ adm1021_INIT_REMOTE_TOS);
adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
- TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+ adm1021_INIT_REMOTE_THYST);
/* Enable ADC and disable suspend mode */
adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
/* Set Conversion rate to 1/sec (this can be tinkered with) */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021
@ 2005-05-19 6:24 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2005-05-19 6:24 UTC (permalink / raw)
To: Rusty Lynch; +Cc: LM Sensors, lkml
On Tue, Aug 12, 2003 at 04:38:13PM -0700, Rusty Lynch wrote:
> While initializing the adm1021 device, the driver is performing a conversion
> from fixed point to Celcius on values that were declaired as Celcius. On
> my Dell Precision 220 this results in a shutdown after a couple of minutes
> running.
>
> This is a very simple patch against the 2.6.0-test3 tree that just removes the
> conversion.
Applied, thanks.
Next time you might want to CC: me to make sure I catch this.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021
2005-05-19 6:24 ` Rusty Lynch
(?)
(?)
@ 2005-05-19 6:24 ` Jean Delvare
-1 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> > While initializing the adm1021 device, the driver is performing a
> > conversion from fixed point to Celcius on values that were declaired
> > as Celcius. On my Dell Precision 220 this results in a shutdown
> > after a couple of minutes running.
> >
> > This is a very simple patch against the 2.6.0-test3 tree that just
> > removes the conversion.
>
> Applied, thanks.
I just checked and this does not apply to our CVS tree. The bug was
introduced by the sysfs conversion (because millidegrees are in use
there, while these are degrees in CVS).
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-05-19 6:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-12 23:38 [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver Rusty Lynch
2005-05-19 6:24 ` Rusty Lynch
2003-08-14 21:32 ` Greg KH
2005-05-19 6:24 ` [PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 Greg KH
2005-05-19 6:24 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.