All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Alok Mooley <rangdi@yahoo.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: Active Memory Defragmentation: Our implementation & problems
Date: 04 Feb 2004 11:56:33 -0800	[thread overview]
Message-ID: <1075924593.27981.458.camel@nighthawk> (raw)
In-Reply-To: <20040204185446.91810.qmail@web9705.mail.yahoo.com>

On Wed, 2004-02-04 at 10:54, Alok Mooley wrote:
> --- Dave Hansen <haveblue@us.ibm.com> wrote:
> 
> > The "work until we get interrupted and restart if
> > something changes
> > state" approach is very, very common.  Can you give
> > some more examples
> > of just how a page fault would ruin the defrag
> > process?
> > 
> 
> What I mean to say is that if we have identified some
> pages for movement, & we get preempted, the pages
> identified as movable may not remain movable any more
> when we are rescheduled. We are left with the task of
> identifying new movable pages.

Depending on the quantity of work that you're trying to do at once, this
might be unavoidable.  

I know it's a difficult thing to think about, but I still don't
understand the precise cases that you're concerned about.  Page faults
to me seem like the least of your problems.  A bigger issue would be if
the page is written to by userspace after you copy, but before you
install the new pte.  Did I miss the code in your patch that invalidated
the old tlb entries?

--dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Alok Mooley <rangdi@yahoo.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: Active Memory Defragmentation: Our implementation & problems
Date: 04 Feb 2004 11:56:33 -0800	[thread overview]
Message-ID: <1075924593.27981.458.camel@nighthawk> (raw)
In-Reply-To: <20040204185446.91810.qmail@web9705.mail.yahoo.com>

On Wed, 2004-02-04 at 10:54, Alok Mooley wrote:
> --- Dave Hansen <haveblue@us.ibm.com> wrote:
> 
> > The "work until we get interrupted and restart if
> > something changes
> > state" approach is very, very common.  Can you give
> > some more examples
> > of just how a page fault would ruin the defrag
> > process?
> > 
> 
> What I mean to say is that if we have identified some
> pages for movement, & we get preempted, the pages
> identified as movable may not remain movable any more
> when we are rescheduled. We are left with the task of
> identifying new movable pages.

Depending on the quantity of work that you're trying to do at once, this
might be unavoidable.  

I know it's a difficult thing to think about, but I still don't
understand the precise cases that you're concerned about.  Page faults
to me seem like the least of your problems.  A bigger issue would be if
the page is written to by userspace after you copy, but before you
install the new pte.  Did I miss the code in your patch that invalidated
the old tlb entries?

--dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  parent reply	other threads:[~2004-02-04 19:56 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-03  4:46 Active Memory Defragmentation: Our implementation & problems Alok Mooley
2004-02-03  4:46 ` Alok Mooley
2004-02-03 21:26 ` Dave Hansen
2004-02-03 21:26   ` Dave Hansen
2004-02-03 22:26   ` Martin J. Bligh
2004-02-03 22:26     ` Martin J. Bligh
2004-02-04  5:09   ` Alok Mooley
2004-02-04  5:09     ` Alok Mooley
2004-02-04  5:24     ` Mike Fedyk
2004-02-04  5:24       ` Mike Fedyk
2004-02-04  5:54     ` Dave Hansen
2004-02-04  5:54       ` Dave Hansen
2004-02-04  6:05       ` Martin J. Bligh
2004-02-04  6:05         ` Martin J. Bligh
2004-02-04  6:22         ` Dave Hansen
2004-02-04  6:22           ` Dave Hansen
2004-02-04  6:29           ` Martin J. Bligh
2004-02-04  6:29             ` Martin J. Bligh
2004-02-04  6:40             ` Dave Hansen
2004-02-04  6:40               ` Dave Hansen
2004-02-04  7:17               ` Martin J. Bligh
2004-02-04  7:17                 ` Martin J. Bligh
2004-02-04  8:30                 ` Andrew Morton
2004-02-04  8:30                   ` Andrew Morton
2004-02-04  6:53             ` Doubt about statm_pgd_range patch Arunkumar
2004-02-04  6:57       ` Active Memory Defragmentation: Our implementation & problems IWAMOTO Toshihiro
2004-02-04  6:57         ` IWAMOTO Toshihiro
2004-02-04  7:10         ` Dave Hansen
2004-02-04  7:10           ` Dave Hansen
2004-02-04  7:50           ` IWAMOTO Toshihiro
2004-02-04  7:50             ` IWAMOTO Toshihiro
2004-02-04 10:33         ` Hirokazu Takahashi
2004-02-04 10:33           ` Hirokazu Takahashi
2004-02-04 18:33       ` Alok Mooley
2004-02-04 18:46         ` Dave Hansen
2004-02-04 18:54           ` Alok Mooley
2004-02-04 18:54             ` Alok Mooley
2004-02-04 19:07             ` Richard B. Johnson
2004-02-04 19:07               ` Richard B. Johnson
2004-02-04 19:18               ` Alok Mooley
2004-02-04 19:18                 ` Alok Mooley
2004-02-04 19:33                 ` Richard B. Johnson
2004-02-04 19:33                   ` Richard B. Johnson
2004-02-05  5:07                   ` Alok Mooley
2004-02-05  5:07                     ` Alok Mooley
2004-02-05 19:03                   ` Pavel Machek
2004-02-05 19:03                     ` Pavel Machek
2004-02-04 19:35               ` Dave McCracken
2004-02-04 19:35                 ` Dave McCracken
2004-02-04 21:59                 ` Timothy Miller
2004-02-04 21:59                   ` Timothy Miller
2004-02-04 23:24                   ` Dave Hansen
2004-02-04 23:24                     ` Dave Hansen
2004-02-05 16:32                     ` Dave McCracken
2004-02-05 16:32                       ` Dave McCracken
2004-02-04 19:37               ` Timothy Miller
2004-02-04 19:37                 ` Timothy Miller
2004-02-04 19:43                 ` Dave Hansen
2004-02-04 19:43                   ` Dave Hansen
2004-02-04 19:59                 ` Richard B. Johnson
2004-02-04 19:59                   ` Richard B. Johnson
2004-02-04 19:56             ` Dave Hansen [this message]
2004-02-04 19:56               ` Dave Hansen
2004-02-05  5:19               ` Alok Mooley
2004-02-05  5:19                 ` Alok Mooley
  -- strict thread matches above, loose matches on Subject: below --
2004-02-04 20:12 Mark_H_Johnson
2004-02-04 20:12 ` Mark_H_Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1075924593.27981.458.camel@nighthawk \
    --to=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rangdi@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.