From: Alex Williamson <alex.williamson@hp.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Paul Jackson <pj@sgi.com>,
mbligh@aracnet.com, haveblue@us.ibm.com,
acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup ACPI numa warnings
Date: Sun, 08 Aug 2004 22:19:44 -0600 [thread overview]
Message-ID: <1092025184.2292.26.camel@localhost.localdomain> (raw)
In-Reply-To: <20040808143631.7c18cae9.rddunlap@osdl.org>
On Sun, 2004-08-08 at 14:36 -0700, Randy.Dunlap wrote:
> On Sat, 7 Aug 2004 10:57:29 -0700 Paul Jackson wrote:
>
> | > And there's nothing in CodingStyle that agrees with you that I could find.
> |
> | >From the file Documentation/SubmittingPatches:
> |
> | 3) 'static inline' is better than a macro
> |
> Oops. Thanks, Paul.
Ok, I was all set to switch to static inlines, but it doesn't work.
Compiling w/ debug on, _dbg is undefined, which is part of the
ACPI_DB_INFO macro, but it only gets setup by the ACPI_FUNCTION_NAME
macro. Guess I got lucky by choosing to do it as a macro. IMHO, it
doesn't really make sense to make the static inline functions more
complicated or hide where they're getting called to make this all work.
So, I think the choices are to stick with the ugly macros or put #ifdefs
around the code and essentially leave it the way it is. Sorry I didn't
give it a more thorough look when originally questioned. Better ideas?
Thanks,
Alex
next prev parent reply other threads:[~2004-08-09 4:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 20:46 [PATCH] cleanup ACPI numa warnings Alex Williamson
2004-08-05 21:01 ` Dave Hansen
2004-08-05 21:01 ` Dave Hansen
2004-08-05 21:25 ` Alex Williamson
2004-08-05 21:25 ` Alex Williamson
2004-08-06 3:35 ` Martin J. Bligh
2004-08-06 3:50 ` [ACPI] " Randy.Dunlap
[not found] ` <20040805205059.3fb67b71.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-07 17:57 ` Paul Jackson
2004-08-07 17:57 ` [ACPI] " Paul Jackson
2004-08-08 21:36 ` Randy.Dunlap
[not found] ` <20040808143631.7c18cae9.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-09 2:53 ` Martin J. Bligh
2004-08-09 2:53 ` [ACPI] " Martin J. Bligh
2004-08-20 18:55 ` Alex Williamson
2004-08-20 18:55 ` [ACPI] " Alex Williamson
2004-08-20 19:22 ` Jesse Barnes
2004-08-09 4:19 ` Alex Williamson [this message]
[not found] ` <1092025184.2292.26.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09 4:52 ` Dave Hansen
2004-08-09 4:52 ` Dave Hansen
2004-08-09 5:10 ` Alex Williamson
[not found] ` <1092028238.2211.5.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09 5:44 ` Dave Hansen
2004-08-09 5:44 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092025184.2292.26.camel@localhost.localdomain \
--to=alex.williamson@hp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=pj@sgi.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.