All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj-sJ/iWh9BUns@public.gmane.org>
To: "Randy.Dunlap" <rddunlap-3NddpPZAyC0@public.gmane.org>
Cc: mbligh-/CzTsIfkJEdBDgjK7y7TUQ@public.gmane.org,
	alex.williamson-VXdhtT5mjnY@public.gmane.org,
	haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Re: [PATCH] cleanup ACPI numa warnings
Date: Sat, 7 Aug 2004 10:57:29 -0700	[thread overview]
Message-ID: <20040807105729.6adea633.pj@sgi.com> (raw)
In-Reply-To: <20040805205059.3fb67b71.rddunlap-3NddpPZAyC0@public.gmane.org>

> And there's nothing in CodingStyle that agrees with you that I could find.

>From the file Documentation/SubmittingPatches:

        3) 'static inline' is better than a macro

        Static inline functions are greatly preferred over macros.
        They provide type safety, have no length limitations, no formatting
        limitations, and under gcc they are as cheap as macros.

        Macros should only be used for cases where a static inline is clearly
        suboptimal [there a few, isolated cases of this in fast paths],
        or where it is impossible to use a static inline function [such as
        string-izing].

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj-sJ/iWh9BUns@public.gmane.org> 1.650.933.1373


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: mbligh@aracnet.com, alex.williamson@hp.com, haveblue@us.ibm.com,
	acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ACPI] Re: [PATCH] cleanup ACPI numa warnings
Date: Sat, 7 Aug 2004 10:57:29 -0700	[thread overview]
Message-ID: <20040807105729.6adea633.pj@sgi.com> (raw)
In-Reply-To: <20040805205059.3fb67b71.rddunlap@osdl.org>

> And there's nothing in CodingStyle that agrees with you that I could find.

>From the file Documentation/SubmittingPatches:

        3) 'static inline' is better than a macro

        Static inline functions are greatly preferred over macros.
        They provide type safety, have no length limitations, no formatting
        limitations, and under gcc they are as cheap as macros.

        Macros should only be used for cases where a static inline is clearly
        suboptimal [there a few, isolated cases of this in fast paths],
        or where it is impossible to use a static inline function [such as
        string-izing].

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

  parent reply	other threads:[~2004-08-07 17:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-05 20:46 [PATCH] cleanup ACPI numa warnings Alex Williamson
2004-08-05 21:01 ` Dave Hansen
2004-08-05 21:01   ` Dave Hansen
2004-08-05 21:25   ` Alex Williamson
2004-08-05 21:25     ` Alex Williamson
2004-08-06  3:35     ` Martin J. Bligh
2004-08-06  3:50       ` [ACPI] " Randy.Dunlap
     [not found]         ` <20040805205059.3fb67b71.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-07 17:57           ` Paul Jackson [this message]
2004-08-07 17:57             ` Paul Jackson
2004-08-08 21:36             ` Randy.Dunlap
     [not found]               ` <20040808143631.7c18cae9.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-09  2:53                 ` Martin J. Bligh
2004-08-09  2:53                   ` [ACPI] " Martin J. Bligh
2004-08-20 18:55                   ` Alex Williamson
2004-08-20 18:55                     ` [ACPI] " Alex Williamson
2004-08-20 19:22                     ` Jesse Barnes
2004-08-09  4:19               ` Alex Williamson
     [not found]                 ` <1092025184.2292.26.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09  4:52                   ` Dave Hansen
2004-08-09  4:52                     ` Dave Hansen
2004-08-09  5:10                     ` Alex Williamson
     [not found]                       ` <1092028238.2211.5.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09  5:44                         ` Dave Hansen
2004-08-09  5:44                           ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040807105729.6adea633.pj@sgi.com \
    --to=pj-sj/iwh9buns@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=alex.williamson-VXdhtT5mjnY@public.gmane.org \
    --cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mbligh-/CzTsIfkJEdBDgjK7y7TUQ@public.gmane.org \
    --cc=rddunlap-3NddpPZAyC0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.