* [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs
@ 2004-09-04 7:55 Dominik Brodowski
2004-09-09 1:45 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Brodowski @ 2004-09-04 7:55 UTC (permalink / raw)
To: davej, jeremy, cpufreq
The encoding of the MSR only works as described in extract_clock() on
certain EST-enabled CPUs. So, limit the actual MSR check to these
CPUs.
Signed-off-by: Dominik Brodowski <linux@brodo.de>
diff -ruN linux-original/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c linux/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
--- linux-original/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2004-08-30 22:50:56.000000000 +0200
+++ linux/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2004-09-04 09:48:49.044458312 +0200
@@ -77,7 +77,7 @@
/* Operating points for current CPU */
static struct cpu_model *centrino_model;
-static int centrino_cpu;
+static const struct cpu_id *centrino_cpu;
#ifdef CONFIG_X86_SPEEDSTEP_CENTRINO_TABLE
@@ -289,7 +289,9 @@
* for centrino, as some DSDTs are buggy.
* Ideally, this can be done using the acpi_data structure.
*/
- if (centrino_cpu) {
+ if ((centrino_cpu == &cpu_ids[CPU_BANIAS]) ||
+ (centrino_cpu == &cpu_ids[CPU_DOTHAN_A1]) ||
+ (centrino_cpu == &cpu_ids[CPU_DOTHAN_B0])) {
msr = (msr >> 8) & 0xff;
return msr * 100000;
}
@@ -457,7 +459,7 @@
break;
if (i != N_IDS)
- centrino_cpu = 1;
+ centrino_cpu = &cpu_ids[i];
if (centrino_cpu_init_acpi(policy)) {
if (policy->cpu != 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs
2004-09-04 7:55 [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs Dominik Brodowski
@ 2004-09-09 1:45 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2004-09-09 1:45 UTC (permalink / raw)
To: Dominik Brodowski; +Cc: Dave Jones, cpufreq list
On Sat, 2004-09-04 at 09:55 +0200, Dominik Brodowski wrote:
> The encoding of the MSR only works as described in extract_clock() on
> certain EST-enabled CPUs. So, limit the actual MSR check to these
> CPUs.
What are the others? EST-enabled P4 machines?
J
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-09 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-04 7:55 [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs Dominik Brodowski
2004-09-09 1:45 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.