From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Mark Lord <lkml@rtr.ca>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2
Date: 14 Sep 2004 14:51:19 -0400 [thread overview]
Message-ID: <1095187885.2007.33.camel@mulgrave> (raw)
In-Reply-To: <20040914183502.GA23277@havoc.gtf.org>
On Tue, 2004-09-14 at 14:35, Jeff Garzik wrote:
> The lock is taken in the SCSI layer with spin_lock_irqsave(), but the
> low-level driver cannot perform the exact opposite,
> spin_unlock_irqrestore(). The best they can do is spin_lock_irq(),
> which isnt 100% the same.
That's what they do if you look.
The eh_ stubs are only called from the eh_ thread, so it's safe to
enable interrupts as well.
The business of the mid-layer taking the locks is an annoying holdover
from the "drivers don't need to do locking" mentality. Unfortunately
most drivers now simply drop the locks immediately they begin an eh_
entry point and reacquire them just prior to returning ... which makes
all the eh code look messy.
James
next prev parent reply other threads:[~2004-09-14 18:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 15:42 [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 Mark Lord
2004-09-14 16:00 ` Alan Cox
2004-09-14 17:14 ` Mark Lord
2004-09-14 17:00 ` Jeff Garzik
2004-09-14 17:27 ` Mark Lord
2004-09-14 17:33 ` Jeff Garzik
2004-09-14 17:51 ` Mark Lord
2004-09-14 17:56 ` Jeff Garzik
2004-09-14 18:03 ` Mark Lord
2004-09-14 18:07 ` Jeff Garzik
2004-09-14 18:08 ` Jeff Garzik
2004-09-14 18:25 ` James Bottomley
2004-09-14 18:35 ` Jeff Garzik
2004-09-14 18:51 ` James Bottomley [this message]
2004-09-15 2:39 ` Mark Lord
2004-09-15 2:47 ` Jeff Garzik
2004-09-15 12:35 ` Mark Lord
-- strict thread matches above, loose matches on Subject: below --
2004-09-14 15:43 Mark Lord
2004-09-14 16:21 ` Jeff Garzik
2004-09-14 16:23 ` Jeff Garzik
2004-09-14 16:39 ` Nathan Bryant
2004-09-14 17:02 ` Jeff Garzik
2004-09-15 4:22 ` Douglas Gilbert
2004-09-15 4:30 ` Jeff Garzik
2004-09-15 12:47 ` Mark Lord
2004-09-15 12:55 ` Jens Axboe
2004-09-15 13:13 ` Matthew Wilcox
2004-09-15 16:14 ` Jeff Garzik
2004-09-15 17:01 ` Jeff Garzik
2004-09-15 7:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095187885.2007.33.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.