All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lsml@rtr.ca>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Mark Lord <lkml@rtr.ca>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2
Date: Tue, 14 Sep 2004 22:39:22 -0400	[thread overview]
Message-ID: <4147AB5A.4060804@rtr.ca> (raw)
In-Reply-To: <1095186343.2008.29.camel@mulgrave>

 >Actually, its only wrong in queuecommand because that can be called in
 >softirq context.
 >
 >Sleeping in the eh paths is fine (as long as you drop the locks that the
 >EH thread has uselessly taken for you).

Good, that's how I understood it as well.

But the locking is certainly a mess as-is in the QStor driver.
Sure, it is actually all technically correct, but hard to follow.

I believe I can remove nearly all of it and really tidy things up
as a result.

Thanks guys, this has been really helpful so far.
-- 
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")

  parent reply	other threads:[~2004-09-15  2:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-14 15:42 [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 Mark Lord
2004-09-14 16:00 ` Alan Cox
2004-09-14 17:14   ` Mark Lord
2004-09-14 17:00 ` Jeff Garzik
2004-09-14 17:27   ` Mark Lord
2004-09-14 17:33     ` Jeff Garzik
2004-09-14 17:51   ` Mark Lord
2004-09-14 17:56     ` Jeff Garzik
2004-09-14 18:03       ` Mark Lord
2004-09-14 18:07         ` Jeff Garzik
2004-09-14 18:08         ` Jeff Garzik
2004-09-14 18:25   ` James Bottomley
2004-09-14 18:35     ` Jeff Garzik
2004-09-14 18:51       ` James Bottomley
2004-09-15  2:39     ` Mark Lord [this message]
2004-09-15  2:47       ` Jeff Garzik
2004-09-15 12:35         ` Mark Lord
  -- strict thread matches above, loose matches on Subject: below --
2004-09-14 15:43 Mark Lord
2004-09-14 16:21 ` Jeff Garzik
2004-09-14 16:23   ` Jeff Garzik
2004-09-14 16:39   ` Nathan Bryant
2004-09-14 17:02     ` Jeff Garzik
2004-09-15  4:22   ` Douglas Gilbert
2004-09-15  4:30     ` Jeff Garzik
2004-09-15 12:47     ` Mark Lord
2004-09-15 12:55       ` Jens Axboe
2004-09-15 13:13         ` Matthew Wilcox
2004-09-15 16:14           ` Jeff Garzik
2004-09-15 17:01       ` Jeff Garzik
2004-09-15  7:02 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4147AB5A.4060804@rtr.ca \
    --to=lsml@rtr.ca \
    --cc=James.Bottomley@SteelEye.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkml@rtr.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.